116233 - Dialog boxes have vague names

Status: VERIFIED FIXED

(Core :: Networking: Cookies, defect, P3)

Description

[phippo]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; SunOS sun4u; en-US; rv:0.9.6) Gecko/20011121
BuildID:    2001112114

The dialog boxes for allowing sites to load images or set cookies have the
window name "Confirm". This is too vague for me as I would like to be able to
auromatically do something with my window manager when some of them pop up.

A better name would be "Confirm allow images" "Confirm allow cookies".

Every dialog box that Mozilla pops up should have a unique name.


Reproducible: Always
Steps to Reproduce:
1. Configure mozilla to prompt you for setting cookies
2. Go almost anywhere on the internet


Expected Results:  >xprop
WM_CLASS(STRING) = "mozilla-bin", "Mozilla-bin"
WM_NAME(STRING) = "Confirm"
WM_ICON_NAME(STRING) = "Confirm"

Comment 1

[Jessie Li]

I couldn't reproduce the bug with Netscape 7.0b1 on solaris.
Every dialog box that Mozilla pops up do have a unique name.
[e-mail]-------------------------

Comment 2

[Tim Phipps]

Well, good for netscape 7.0b1.

Mozilla 1.0 calls the dialog boxes for Image-loading confirmation and
cookie-storing-confirmation "Confirm", what does netscape 7.0b1 call them?

Comment 3

[Bart van Bragt]

Confirmed on Linux, Build 2002072204

Comment 4

[timeless]

uid is being phased out.

Comment 5

[Mike Connor [:mconnor]]

I don't see a bug for this anywhere.  The dialog names should definitely be more
specific, and that's trivial.

Comment 6

[Mike Connor [:mconnor]]

not going to make 1.7a, but it'll be in 1.7b

Comment 7

[Mike Connor [:mconnor]]

Attachment: change string to "Confirm setting cookie"

"Confirm setting cookie" is a little better than "Confirm"

Comment 8

[Alec Flett]

Comment on attachment 141333 [details] [diff] [review]
change string to "Confirm setting cookie"

gag. "Confirm setting cookie" is incredibly awkward. Is it a statement? a
question? An imperitive? A user might wonder if that should be "Confirm cookie
setting" or something, which I'm not sure is any better.


How about "Cookie confirmation"? That one is at least an obvious noun phrase.

Comment 9

[Alec Flett]

Looking back over the beginning of this bug, I agree that "Confirm" by itself is
awkward as well.. but titles of windows in general are titles or descriptions of
the contents of the box, not actions. The actions, questions, or requests made
by the window should be in the text of the window, not the title bar. 

I think that trying to find an appropriate form of the word "set" is a lost
cause, just considering it is the single largest entry in the entire OED.

Comment 10

[Mike Connor [:mconnor]]

Fixed in another prompt bug.  Resolving.

Comment 11

[Jason Bassford]

Without identifying the other "prompt bug" this should be resolved as WORKSFORME.

Comment 12

[Mike Connor [:mconnor]]

guess I could have been clear that I fixed it in another patch for another bug,
but since it was me that fixed it, I figured that it wasn't worth digging into
that too much.

Bug 230624 is the bug for the sticklers.

Comment 13

[Jason Bassford]

.