116375 - unix needs option to customize splash screen

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, enhancement)

Description

[Iuri Fiedoruk]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i586; en-US; rv:0.9.6) Gecko/20011121
BuildID:    

In new builds splash is working on unix, but It's not possible to user use a
customized splash screen.
Mozilla should look for a splash.xpm (or .png) on it's directory and use it
instead of the default splash screen that is hidden somewhere (can someone tell
me where is it? I want to change it while this bug isn't fixed).

Reproducible: Always
Steps to Reproduce:
1.open mozilla with -splash
2.
3.

Actual Results:  the red splash with a green dragon spiting fire and a mozilla
name burning

Expected Results:  the splash.xpm placed on mozilla directory should be shown

Comment 1

[Matthias Versen [:Matti]]

a file "mozilla.bmp" in mozilla´s directory works on windows.
(bug 29775)

-> XP APPS

Comment 2

[Iuri Fiedoruk]

Yes, we need the same bahavior on unix.
But using a xpm or png instead of bmp :)

Comment 3

[Andy Lyttle]

I would think that multiple formats should be allowed, and they should all work
on all platforms.  No reason a bmp file can't work on UNIX or Mac OS.

Comment 4

[Grey Hodge (jX)]

Bug 27446 had a patch that would look for a mozilla.xpm but it was removed for a
speed increase inloading the splash. Should be trivial to add that part of the
code, but if no mozilla.xmp is found, the default which is built in gets used.

Comment 5

[Ben Bucksch (:BenB)]

Another advantage: A comon hack for users to disable splash-screens is to just
remove them. They expect that the splash screen is not shown then, but
everything works as usual otherwise.

Comment 6

[Asa Dotzler [:asa]]

-> default assignee

Comment 7

[Peter Trudelle]

->future/bryner

Comment 8

[parish]

Attachment: Patch to add the functionality

Comment 9

[parish]

I just realized; I hardcoded the filename as mozilla.xpm which, although it
would work, would be a bit silly on NS.

Win and OS/2 find <appname> and append .BMP rather than hardcoding it but in the
patch referred to in comment 4 it was hardcoded, albeit as the more neutral
splash.xpm.

Which is better, hardcoding it (as splash.xpm) or getting <appname> like Win and
OS/2?

Comment 10

[Ben Bucksch (:BenB)]

I vote for splash.*. It is consistent across Mozilla distros, neutral and makes
the meaning clear.

Comment 11

[parish]

Win and OS/2 use <appname>.BMP for /user/ splash screens, only the default
embedded image is called splash.*

Comment 12

[parish]

Attachment: mozilla.xpm->splash.xpm

BTW Ben, I agree that splash.* would be a better choice, even for user splash
screens, but I don't think we should change Win & OS/2 as we would have a lot
of new bugs filed. User splash screens are obviously very popular - there's 66
at deskmod.com alone.

Comment 13

[parish]

Attachment: Removed some rogue code

Duh! Missed removing some code I'd accidentally pasted in.

Comment 14

[Robert Kaiser]

parish:
you should request review from somebody specific, else I don't think people will
react to the request...

Comment 15

[parish]

Comment on attachment 106599 [details] [diff] [review]
Removed some rogue code

Thanks for the tip Kairo

Comment 16

[Brian Ryner (not reading)]

Comment on attachment 106599 [details] [diff] [review]
Removed some rogue code

>@@ -69,10 +71,26 @@
>   if (!splash_xpm[0])
>     return NS_OK;
> #endif
>-  /* create a pixmap based on xpm data */
>-  GdkPixmap* pmap = gdk_pixmap_colormap_create_from_xpm_d(NULL,
>+
>+  nsCAutoString path(PR_GetEnv("MOZILLA_FIVE_HOME"));
>+
>+  if (path.Equals("")) {

Change this to path.IsEmpty(). r=bryner with that change.

Comment 17

[parish]

Attachment: path.Equals("") -> path.IsEmpty()

Thanks bryner

Comment 18

[Matthias Versen [:Matti]]

Please request aproval after you got the reviews

Comment 19

[jag (Peter Annema)]

Comment on attachment 112876 [details] [diff] [review]
path.Equals("") -> path.IsEmpty()

sr=jag

Comment 20

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 112876 [details] [diff] [review]
path.Equals("") -> path.IsEmpty()

>+  nsCAutoString path(PR_GetEnv("MOZILLA_FIVE_HOME"));

Shouldn't this use the directory service?


Also, what is the startup performance cost of this?  This code only gets
executed if -splash is on the command line, right?

Comment 21

[KENZ (Kenji Irie)]

dbaron:
right.
AFAIK, this fix affects only startup with splash screen.

this is what i want. thanks for your hack parish.

Comment 22

[Brian Ryner (not reading)]

dbaron: this code is executed prior to XPCOM startup, so I don't think the
directory service is available.

Comment 23

[Asa Dotzler [:asa]]

Comment on attachment 112876 [details] [diff] [review]
path.Equals("") -> path.IsEmpty()

not needed for 1.3. please hold 'till we open for 1.4alpha.

Comment 24

[KENZ (Kenji Irie)]

why no one check in this to trunk?

Comment 25

[Robert Kaiser]

KENZ:
because the one who made the patch didn't do it himself and has asked nobody
else to do it.

Comment 26

[KENZ (Kenji Irie)]

kairo: i see. and sorry for spam.
i said that because i thought anyone who can check in can do so, and i want this.

Comment 27

[parish]

The reason that "the one who made the patch didn't do it himself" is because I
don't have commit privs and the reason I haven't asked anyone else to do it
(yet) is because it was denied approval for check-in (see comment 23) and,
AFAIK, such approval is still required - even though there appears to be a 1.4a
branch now.

Perhaps I don't understand the branching system properly and that it can now be
checked-in, in which case please can someone do this for me? Thanks.

Comment 28

[Robert Kaiser]

parish:

the thing that claims to be some "1.4a" currently is the trunk, and you don't
need approval for trunk unless it's stated so on tinderbox.

I'll do the checkin for you tomorrow (europe time), as today I have to celebrate
carnival here ;-)

I'll try to apply the patch on my cvs tree now to see if that does apply and
build cleanly here. If anything breaks, I'll tell you...

Comment 29

[Robert Kaiser]

Checking in xpfe/bootstrap/nsNativeAppSupportGtk.cpp;
/cvsroot/mozilla/xpfe/bootstrap/nsNativeAppSupportGtk.cpp,v  <-- 
nsNativeAppSupportGtk.cpp
new revision: 1.12; previous revision: 1.11
done

I did the checkin for [e-mail], FIXED.