116495 - numeral zero disappears in Prefs | Composer | maximum number of pages listed

Status: RESOLVED FIXED

(SeaMonkey :: Preferences, defect, P3)

Description

[Andrew Hagen]

Actual behavior: Go to Preferences | Composer | Recent Pages Menu | Maximum
Number of Pages Listed, and set it to 0 (zero). Close preferences. Go back to
that setting. See that the box has no value at all. The box is totally white.

Expected behavior: Go to Preferences | Composer | Recent Pages Menu | Maximum
Number of Pages Listed, and set it to 0 (zero). Close preferences. Go back to
that setting. See that 0 (zero) is still listed.

Comment 1

[sairuh (rarely reading bugmail)]

charley?

Comment 2

[sairuh (rarely reading bugmail)]

i'm wondering if this is expected behavior. but i can certainly understand being
consistent and displaying '0' rather than a blank textfield.

also see this on linux, 2001.12.21.08 comm bits.

Comment 3

[Charles Manske]

The pref value is correctly stored as "0". The problem is when filling in that 
value in the editfield. The code that does that is not Composer-specific, but
is done by the global "prefs dialog" code, which reads/sets the pref values
via the widget IDs in the "_elementIDs" array in pref-composer.xul.
It probably is testing for "true" before setting the value, so the "0" is 
preventing the editfield from display that numeral.

Comment 4

[sairuh (rarely reading bugmail)]

samir, would you be able to fix this? punt as needed!

Comment 5

[Samir Gehani]

Attachment: Don't test for null since values can be ints in the generic_set() call.

Comment 6

[Samir Gehani]

morse, please r.
alecf, please sr.

Comment 7

[Stephen P. Morse]

Comment on attachment 63320 [details] [diff] [review]
Don't test for null since values can be ints in the generic_set() call.

r=morse

Comment 8

[Alec Flett]

Comment on attachment 63320 [details] [diff] [review]
Don't test for null since values can be ints in the generic_set() call.

hmmm.. I think we had problems with this before where string prefs became
"null" if they didn't have a default value.. can you check some other pages on
a new profile, see if you see "null" anywhere?

Comment 9

[Samir Gehani]

Yup, I had a similar afterthought.  So I'm thinking we'll check for null and
maybe even an empty string ("") but if it's a 0 we should let it through.  I'll
retest with a modified patch.  Thanks for calling this out.

Comment 10

[Samir Gehani]

-> Future

Comment 11

[Paul Wyskoczka]

Marking nsbeta1- per Nav triage team.

Comment 12

[Andrew Hagen]

It's now called "maximum number of pages listed" in Edit | Preferences | Composer.

Comment 13

[Andrew Hagen]

This is fixed in trunk at latest by build ID: 2002062713. 

Resolving Worksforme.

Thank you for fixing this!

Comment 14

[Andrew Hagen]

This is fixed on trunk. It doesn't seem important enough to go into the branch.
Thus, it should be resolved fixed, rather than left open.

Comment 15

[Andrew Hagen]

Can this be resolved fixed to get it off the radar?

Comment 16

[Andrew Hagen]

Marking fixed.