1165860 - [ServiceWorkers] We need a more seamless way of falling through the route rather than forcing middleware developers to add the "work-only-if-no-response-yet" code pattern at the beginning of its code

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Get to a consensus on how we want to do this and implement this :)

Comment 2

[Salvador de la Puente González [:salva]]

Attachment: Implement the new onFetch() workflow and API for middlewares

Hi Francisco. Long but fully tested and working. Can you review, please?

Comment 3

[Salvador de la Puente González [:salva]]

Notice I stop to clone request and responses. I prefer the user to crash rather than perform unneeded operations if goals for SWW are "lean and fast".

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8615166 [details] [review]
Implement the new onFetch() workflow and API for middlewares

Just left some comments, tiny ones, but this work looks amazing :)

Amazing that we keep the compatibility and have the new mechanism. We should think in the future if we remove the compatibility, but so far looks like a win.

Thanks a lot for the fantastic work!

Comment 5

[Salvador de la Puente González [:salva]]

Comment on attachment 8615166 [details] [review]
Implement the new onFetch() workflow and API for middlewares

I've updated the specification and implementation in separated commits. Can you double-check the implementation, please?

Comment 6

[Salvador de la Puente González [:salva]]

I added three commits more about warning the developer about errors in the middleware pipeline. Problem is that according with the specification [1], if `.respondWith()` is passed with a rejecting promise or a promise resolving in a thing different than a Response instance, the client's fetch will fail with network error. I would want to give an opportunity for the developer to see the error in the console as well.

[1] http://www.w3.org/TR/service-workers/#respond-with-method

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8615166 [details] [review]
Implement the new onFetch() workflow and API for middlewares

Excellent job, everything pretty clear and well documented.

I really like the flexibility but everything is looking quite consistent.

Just one thing before merging, we should bump the version both for npm package and bower to 0.1.0, wdyt?

Comment 8

[Salvador de la Puente González [:salva]]

master: f31ce642b4b68307602c4b8f1cbb3d0a1465c07b