116752 - Manage Bookmarks does not retain custom column settings

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Mark]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.7) Gecko/20011221
BuildID:    2001122106

Within the "Manage Bookmarks" Window, the changes I made to customize it's
appearance are not retained after I close the window.  I have tried adding and
removing the different columns but whenever I open the "Manage Bookmarks" the
same columns are shown.  'Name' and 'Location' (which seem to be the default)
always appear even when others are specified and if one of the defaults has been
removed.  My simple example is to remove 'Location' from the visible columns. 
It's always displayed after restart and re-opening the bookmarks.

Reproducible: Always
Steps to Reproduce:
1.  Open "Manage Bookmarks"  (Through toolbar or Control-B)
2.  Using the mouse, click on the tab which changes shown columns
3.  Uncheck 'Location'
4.  Close "Manage Bookmarks" Window
5.  Open "Manage Bookmarks"

Actual Results:  When using the stated steps, everytime the bookmarks window is
opened the 'Location' column is visible.  This occurs even when the the item is
disabled and the window is re-opened.  I also tried shutting down the browser
but got the same result.

Expected Results:  If the 'Location' column is disabled, every time the "Manage
Bookmarks" window is open that column should not be visible.  Any change to the
columns should be saved.  (Similar to how the History Window handles these changes.)

Comment 1

[Boris Zbarsky [:bzbarsky]]

To blake

Comment 2

[Pete Zha]

There is another problem maybe in same situation...

The state of columns can't be saved
Version  on mozilla0.9.4, mozilla0.9.7 even in trunk
Platform Sun
OS Solaris8


Step of reproduce:
   1. Select Bookmarks|Manage Bookmarks.
   2. Click the icon on the far right of the column headers.
   3. Check two of the items(columns),such as 'Keyword' and 'Description'.
   4. Uncheck two items.
   5. Recheck two items
   6. Open Bookmarks again.

 
Expected result:
   After step #6,items 'Keyword' and 'Description' still appear on the list
 
Actual result:
   After step #6,items 'Keywork' and 'Description' disappear on the list

Comment 3

[Chris Lyon]

*** Bug 113534 has been marked as a duplicate of this bug. ***

Comment 4

[Chris Lyon]

*** Bug 114306 has been marked as a duplicate of this bug. ***

Comment 5

[Pete Zha]

Attachment: Patch to fix this bug

Don't know why remove the "hidden" attribute.
Change to setAttribute("hidden", "false") will work fine.

Comment 6

[Chris Lyon]

*** Bug 121080 has been marked as a duplicate of this bug. ***

Comment 7

[Blake Ross]

Why would that patch fix it if bookmarks uses outliner? -> ben

Comment 8

[Pete Zha]

The outliner also use removeAttribute.
So It has same problem.

Comment 9

[Margaret Chan]

I guess that's the same reason for the fix in:

http://bugzilla.mozilla.org/show_bug.cgi?id=123285

Comment 10

[Chris Lyon]

*** Bug 124974 has been marked as a duplicate of this bug. ***

Comment 11

[Chris Lyon]

*** Bug 121286 has been marked as a duplicate of this bug. ***

Comment 12

[Chris Lyon]

This looks fixed to me (probably from Ben's fix for bug 128815).

WFM 2002031303 on WinXP.

Comment 13

[mbalbo]

This was broken on my system for a long time (it used to work i don't remember
when). But it works for me now with Mozilla 1.0 RC1. Now i can add columns in
the bookmark manager and they stay visible after closing and opening it.
Build 2002041711 on Win98SE

Comment 14

[Joe Infla]

marking fixed per testing and comment 12 & 13.