1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Fernando Jiménez Moreno [:ferjm]]

Update service workers via about:serviceworkers won't work without this.

This is a follow up of bug 1162088.

Comment 1

[José Antonio Olivera Ortega [:jaoo]]

Bug 1155153 is about to land. What makes sense is to work in this bug on top of the patches from bug 1155153. So lets block here on bug 1155153.

Comment 2

[José Antonio Olivera Ortega [:jaoo]]

Attachment: MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

Enable service workers on b2g

Comment 3

[José Antonio Olivera Ortega [:jaoo]]

Attachment: MozReview Request: Bug 1155153 - about:serviceworkers should work in e10s mode, r=nsm, r=bholley

Bug 1155153 - about:serviceworkers should work in e10s mode, r=nsm, r=bholley

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Attachment: MozReview Request: Bug 1155153 - [e10s] about:serviceworkers should work in e10s mode. Update B2G implementation. r=baku

Bug 1155153 - [e10s] about:serviceworkers should work in e10s mode. Update B2G implementation. r=baku

Comment 5

[José Antonio Olivera Ortega [:jaoo]]

Attachment: MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=fabrice

Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=fabrice

Comment 6

[José Antonio Olivera Ortega [:jaoo]]

Attachment: Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/30503

Comment 7

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

Comment 8

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8617355 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/30503

Arthur, would you mind to review this please? Thanks!

Comment 9

[[:fabrice] Fabrice Desré]

Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

https://reviewboard.mozilla.org/r/10611/#review10023

Looks good to me.

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 8617312 [details]
MozReview Request: Bug 1171915 - about:serviceworkers in b2g should use originAttributes when calling ServiceWorkerManager. r=baku,fabrice

https://reviewboard.mozilla.org/r/10611/#review10093

Ship It!

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8617355 [details] [review]
Pointer to Github PR https://github.com/mozilla-b2g/gaia/pull/30503

r=me, thanks!

Comment 12

[José Antonio Olivera Ortega [:jaoo]]

Hit the following assertion failure when updating the SW via about:sw in b2g. IIRC :baku said this will be fixed by bug 1169044 so lets set the dependency here. Andrea, am I right? Thanks!

Assertion failure: data, at /Volumes/firefoxos/dev/mozilla-central/xpcom/base/nsCycleCollector.cpp:3973
#01: mozilla::OriginAttributes::PopulateFromSuffix(nsACString_internal const&) (nsRefPtr.h:99, in XUL)

Comment 13

[Pulsebot]

https://hg.mozilla.org/integration/b2g-inbound/rev/56b26cd91e76

Comment 14

[José Antonio Olivera Ortega [:jaoo]]

(In reply to Pulsebot from comment #13)
> https://hg.mozilla.org/integration/b2g-inbound/rev/56b26cd91e76

Latest try before landing the patch above at:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=34c10f9e38f3

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/56b26cd91e76

Comment 16

[José Antonio Olivera Ortega [:jaoo]]

checkin-needed for the gaia bits here. Thanks!

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/3722c4dcff985412ced777b76a2ead8b0ee04194

Comment 18

[Noemí Freire (:noemi)]

Hi,

Just adding that the update process in about:sw in b2g has been just tested in master and it works as expected. So it seems the crash raised in comment 12 has been fixed by Bug 1169044. Thanks!

Environmental variables:
Flame device
Build Id: 20150629151042
Gecko:13c42a5
Gaia: 3722c4d
Platform version: 41.0a1