Closed Bug 117594 Opened 23 years ago Closed 21 years ago

resizing form manager window (edit form info) doesn't resize text fields

Categories

(Toolkit :: Form Manager, defect, P4)

Product:
Toolkit
Component:
Form Manager
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: jmd, Assigned: neil)

References

Details

Attachments

(2 files, 2 obsolete files)

screencap
76.75 KB, image/png
Details
Better approach
2.93 KB, patch
dwitte
: review+
alecf
: superreview+
Details | Diff | Splinter Review
In form manager, under URL specific, the three text fields are rediculously small. Fair enough, the window has to be small to fit on 640x480. My res is 4x that though, but when I resize the dialog, the form elements don't grow. Probably some sort of gravity property on the form could be set to get them to scale with the window? Incoming screenshot.
Attached image screencap —
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Target Milestone: mozilla0.9.9 → mozilla1.0.1
Target Milestone: mozilla1.0.1 → mozilla1.1alpha
Priority: -- → P4
Target Milestone: mozilla1.1alpha → mozilla1.2beta
Target Milestone: mozilla1.2beta → mozilla1.3beta
This would probably be trivial, like some flex attributes or whatever (I am by no means XUL expert). Reassigning to new module owner.
Assignee: morse → dveditz
Severity: normal → minor
Status: ASSIGNED → NEW
Target Milestone: mozilla1.3beta → ---
Win2k, too. I'll have a look...
OS: Linux → All
Hardware: PC → All
taking, adjusting summary
Assignee: dveditz+bmo → durbacher
Summary: resizing form manager window doesn't resize text fields → resizing form manager window (edit form info) doesn't resize text fields
*** Bug 200547 has been marked as a duplicate of this bug. ***
In other components the ax-assignee should be cc'd. Don't know if this applies here, also...
Attached patch preferred patch (obsolete) — — Splinter Review
Flexes everything and shows a scrollbar for the grid items when the space does not suffice.
Attached patch alternative patch (obsolete) — — Splinter Review
Alternative patch that cleans up the file even more, but has several dravbacks: the groupbox caption is not written across the border, but below. And the grid description labels at the top are also scrolled and not visible anymore after scrolling.
Comment on attachment 139692 [details] [diff] [review] preferred patch Requesting review from Neil.
Attachment #139692 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 139694 [details] [diff] [review] alternative patch Just so you're sure :-)
Attachment #139694 - Flags: review-
Attached patch Better approach — — Splinter Review
Attachment #139692 - Attachment is obsolete: true
Attachment #139694 - Attachment is obsolete: true
Comment on attachment 139692 [details] [diff] [review] preferred patch Clearing review request. That second patch was never intended to get review for, by the way...
Attachment #139692 - Flags: review?(neil.parkwaycc.co.uk)
Attachment #139721 - Flags: review?(dwitte)
Yours now.
Assignee: durbacher → neil.parkwaycc.co.uk
Attachment #139721 - Flags: review?(dwitte) → review+
Attachment #139721 - Flags: superreview?(alecf)
Comment on attachment 139721 [details] [diff] [review] Better approach jeeze, I wonder how much JS namespace cruft we would save if nsIXULElement had a CreateXULElement? sr=alecf
Attachment #139721 - Flags: superreview?(alecf) → superreview+
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.13) Gecko/20080313 SeaMonkey/1.1.9 FF no longer has a Forms Manger UI so I tested this in SeaMonkey. Verified.
Status: RESOLVED → VERIFIED
Product: Core → Toolkit
QA Contact: tpreston → form.manager
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: