117864 - regression: reply to mail with big attachment is slow to quote

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

reply to eudora mail is slow to quote

I've got a sample email where reply is really, really slow.

it's a message with a small body, with a big attachment.

Comment 1

[(not reading, please use [e-mail] instead)]

ok, I know what's going on.

the fix that cavin made is still valid, and in the tree, but we aren't 
reparsing the spec (nsImapUrl::ParseListOfMessageIds()) after we 
append "header=quotebody" to the spec.

fyi, he's the bug that contains cavin's fix: 
http://bugzilla.mozilla.org/show_bug.cgi?id=101480

so we're not fetching the body, we're fetching the whole beast.

this may have broken when quoting broke during that "store offsets" url 
landing, or when I tried to fix the code after quoting broken.

Comment 2

[(not reading, please use [e-mail] instead)]

working on a fix, discussing with bienvenu over aim.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: patch.

I'm leaving it up to the classes that derive from nsIMsgMailNewsUrl to decide
what setters require a reparse, in order to minimize the reparsing and the keep
the base class clean.  

for this problem, imap url and mailbox url need to reparse after setspec and
setquery, but that's it.  (setport, setfilename, sethostname, etc, don't need
it.)  and for news, we don't need to reparse at all.

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 63398 [details] [diff] [review]
patch.

whoops, wrong patch.

Comment 5

[(not reading, please use [e-mail] instead)]

the was the right patch, but I think there is a bug in calling GetPath() after 
calling SetQuery().

working on it...

Comment 6

[(not reading, please use [e-mail] instead)]

ok, GetPath() does the right thing after we call SetSpec(), just not after we 
do SetQuery().

I'll continue to investigate.

Comment 7

[(not reading, please use [e-mail] instead)]

I'm blocked by the GetPath() after the SetQuery() problem (see bug #118143)

I could work around it using SetSpec(), but I'd rather wait and do it right.

Comment 8

[(not reading, please use [e-mail] instead)]

Attachment: patch

this is the patch, just waiting for that SetQuery / GetPath issue to be fixed.

Comment 9

[David :Bienvenu]

Comment on attachment 63505 [details] [diff] [review]
patch

sr=bienvenu

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

note to QA, you can't verify until darin lands his fix for #118143

Comment 11

[(not reading, please use [e-mail] instead)]

really marking fixed.

Comment 12

[Sheela Ravindran]

Compared replying to a message with 14 MB attachment prior to fix and after fix.
I was able to see a significant change in time to quote with large attachment 
after the fix and was very fast.  Marking verified. Now this problem has been  
fixed now on Build: 2002-01-08-06 on win98, linux, Mac OS X.