117955 - Greyed link toolbar icons have a shadow

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Joe McCabe]

The greyed icons in the links toolbar appear to have masks that don't fit the
graphic. The is a large amount of inappropriate and awkward white space around
the icons.

Potentially related to bug 116259 and bug 113100.

Comment 1

[Joe McCabe]

Attachment: Screen scrape showing bad masks

Comment 2

[R.K.Aa.]

i believe this may have been a duplicate of bug 113100.
Can you test again with a build with the fix?

Comment 3

[Joe McCabe]

Attachment: After Icons have been redrawn

While 113100 certainly made the problem more ugly, I believe the problem with
the masks not matching the images still persists (though this may simply be a
style issue - Is this per design for Modern?).

Attachment is a blowup of Modern from 2002012208

Comment 4

[alge]

This one should block Bug 103053 ..

Comment 5

[R.K.Aa.]

Reporter: Your last screenshot shows the buttons enlarged, and it's how they are
supposed to look. There are no "masks" used for the images - they are gifs, and
are made to look this way. You can confirm that by downloading and unzipping
attachment http://bugzilla.mozilla.org/showattachment.cgi?attach_id=65388

Resolving as invalid.

Comment 6

[Joe McCabe]

Yes, they're enlarged to make the white edges easier to see.

If the white along the right edge is as designed then the design is inconsistent
with the greyed icons/widgets from other toolbars.

Comment 7

[Boris Zbarsky [:bzbarsky]]

reopening.  This is a valid problem with the images.

Comment 8

[Kai Lahmann (is there, where MNG is)]

there is something small.. hm..

it it maybe in the icons?

Comment 9

[Sitsofe Wheeler]

Confirming with 1.0RC1 Windows and Linux. Setting OS to All.

Comment 10

[timeless]

um, i'd imagine that's intentional, has anyone asked the author?

the idea is to have a disabled shadow. if you use IE, you'll see the effect
(although there the shadow is bottom/right). classic/newclassic also have
shadows for disabled icons.

Comment 11

[Karl Guertin]

Attachment: zip of icons without highlight/shadow

Since I was CCed to this bug, I guess I'll post a comment. The icons were like
that when I messed with them, I just went with what was there. I think the
icons don't fit the theme, so I stripped the offending pixels out of the file
I'm attaching. The files inside go in the mozilla/themes/modern/navigator/btn1
directory of the source tree.

Comment 12

[Joe McCabe]

In reply to comment #10: It's not that it's not intentional, it's an issue of
visual inconsistency. If nobody cares then don't fix it. The only issue it
creates is that the theme does not have cohesion.

Given that a fix is so trivial (thanks Karl) I don't see why it shouldn't be
addressed.

Comment 13

[Mats Palmgren (inactive)]

IMO, the proposed new icons looks better than the current ones.
Adding 'patch' keyword.

Comment 14

[Stefan Borggraefe]

Comment on attachment 96539 [details]
zip of icons without highlight/shadow

bz: Can you r or even r+sr these icons? I tested them and they definitly look
better. I'm asking you because you also reviewed the current icons in bug
113100. Thanks! :-)

Comment 15

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 96539 [details]
zip of icons without highlight/shadow

That was before we had people reasonably responsible for such things.  This
should get review from one of the visual identity people or something like
that.

Comment 16

[Stefan Borggraefe]

Comment on attachment 96539 [details]
zip of icons without highlight/shadow

Ok, let's try the Mozilla Visual Identity Team leader then.

Steven, can you review these images?

Comment 17

[Steven Garrity [:sgarrity]]

Sorry for the delay on review - are there any screenshots that show a
before/after of the graphics in context?

Also, will this apply to both Firefox and Mozilla, or just Mozilla?

Comment 18

[Stefan Borggraefe]

Attachment: Screenshot with the current images

Comment 19

[Stefan Borggraefe]

Attachment: Screenshot with the new icons from attachment 96539

Comment 20

[Stefan Borggraefe]

(In reply to comment #17)
> Sorry for the delay on review - are there any screenshots that show a
> before/after of the graphics in context?

I just attached two screenshots to this bug.
 
> Also, will this apply to both Firefox and Mozilla, or just Mozilla?

This only affects Mozilla's Modern theme.

Comment 21

[Stefan Borggraefe]

Comment on attachment 96539 [details]
zip of icons without highlight/shadow

Neil, can you give r or even r+sr for these images? Thanks! :-)

Comment 22

[[e-mail]]

Sure, if Steven Garrity doesn't want to review you can have r+sr from me.

Comment 23

[Steven Garrity [:sgarrity]]

I'm not sure I'm the best person to review - most of my work has been on
Firefox/Thunderbird/Mozilla.org and not the Mozilla Suite. That said, the
updated screenshots look fine to me.

Comment 24

[Stefan Borggraefe]

Fix checked in.