1185504 - [ServiceWorkers][toolkit] Add performance marks to the library

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

We will need to add performance marks to the library, which should not be present when we have a release version.

We should add a new target to the build process to get the debug information, and those markers should be removed in the normal build process.

Comment 1

[Francisco Jordano [:arcturus] [:francisco]]

Attachment: Pointer to github pull request

First feedback pass

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8636071 [details] [review]
Pointer to github pull request

My only comment is to add a *.md explaining the marks.

Notice performance marks for install/fetch/activate events are placed just after the respond in a synchronous way. This is correct but not complete because we should add another mark after the asynchronous `.respondWith()` completes. I don't know if this is even possible but what is possible is to add the mark after the promise resolves. This way, with no middlewares installed, we could take into account the overhead of the asynchronous path.

I don't know if you got my point. Let me know.

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8636071 [details] [review]
Pointer to github pull request

Hi Salva,

I've added your recommendations and added a .md page for information about how to get the debugging build and what the performance marks are for.

Please feel free to add a pr to this one with the extra data that you would like to add.

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8636071 [details] [review]
Pointer to github pull request

Code LGTM. Let's add the middleware measurements in a follow up.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Landed:

https://github.com/gaia-components/serviceworkerware/commit/77302995284de5ab8a61bccd2f4acb52da504090