Closed
Bug 118587
Opened 24 years ago
Closed 24 years ago
unnecessary strdup()/free() in nsJARChannel.cpp, function GetContentType()
Categories
(Core :: Networking, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: bernard.alleysson, Assigned: darin.moz)
References
()
Details
(Keywords: perf)
Attachments
(1 file)
|
1.88 KB,
patch
|
Details | Diff | Splinter Review |
just see URL
|
Reporter | |
Comment 1•24 years ago
|
||
on launching mozilla with about:blank, this saves about 140 calls to
strdup()/free()
|
||
Comment 3•24 years ago
|
||
Comment on attachment 63830 [details] [diff] [review]
Remove a call to strdup()/free()
Please take a look at the discussion in bug 118135 ("change nsCRT::memcpy to
memcpy") - what about replacing the |nsCRT::strlen()| with plain ANSI-C
|strlen()| ?
|
|
Assignee | |
Comment 4•24 years ago
|
||
is this a significant performance win?
|
|
||
Updated•24 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 5•24 years ago
|
||
my patch for bug 124042 happens to include very similar changes. marking as
dependent on that bug.
Depends on: 124042
|
|
Assignee | |
Comment 6•24 years ago
|
||
fixed now that the patch for bug 124042 has landed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•