118636 - Date format change in SpiderMonkey should be done in Rhino

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect)

Description

[Phil Schwartau]

This is the Rhino version of bug 118266 against SpiderMonkey. 
Note the resulting change in SpiderMonkey date format: 

BEFORE FIX:
js> Date();
Mon Jan 07 13:40:34 GMT-0800 (Pacific Standard Time) 2002

AFTER FIX:
js> Date();
Mon Jan 07 2002 13:40:34 GMT-0800 (Pacific Standard Time)


RHINO CURRENTLY:
js> Date();
Mon Jan 07 13:40:34 GMT-0800 (PST) 2002


This is in sync with the old style. Can we change it to be consistent
with the new SpiderMonkey style? Note: the examples I've given are on
WinNT. There are slight differences on the other platforms, but the 
gist of the issue is the same.

Comment 1

[Phil Schwartau]

Note: I have modified the following testcases to take the new 
SpiderMonkey date format into account:
 
            mozilla/js/tests/ecma_3/Date/15.9.5.4
            mozilla/js/tests/ecma_3/Date/15.9.5.7

The latter is irrelevant to Rhino: it is on the rhino-n.tests skip list.
However, the former is now failing when tested against Rhino.

Comment 2

[Brendan Eich [:brendan]]

The reason for the change is to match PR_ParseTimeString and its precursor
xptime.c code in Nav1-4, which is used when parsing cookie expiration times.  So
besides syncing Rhino and SpiderMonkey, Rhino may benefit in environments where
its Date implementation is used to produce a cookie expiration time.

/be

Comment 3

[Norris Boyd]

Fixed: 
Checking in src/org/mozilla/javascript/NativeDate.java;
/cvsroot/mozilla/js/rhino/src/org/mozilla/javascript/NativeDate.java,v  <--  Nat
iveDate.java
new revision: 1.29; previous revision: 1.28
done

Comment 4

[Phil Schwartau]

Verified FIXED on WinNT in rhino, rhinoi shells built today:

js> Date()
Wed Jan 09 2002 11:25:57 GMT-0800 (PST)

In addition, the testcase mozilla/js/tests/ecma_3/Date/15.9.5.4.js
is now passing in both Rhino shells -

Comment 5

[Igor Bukanov]

Targeting as resolved against 1.5R3