Closed
Bug 119053
Opened 24 years ago
Closed 24 years ago
backspace can delete two br's instead of one
Categories
(Core :: DOM: Editor, defect)
Core
DOM: Editor
Tracking
()
VERIFIED
FIXED
mozilla0.9.8
People
(Reporter: mozeditor, Assigned: mozeditor)
Details
Attachments
(1 file)
|
1.79 KB,
patch
|
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
Steps:
1) in compser, enter:
123
456
2) place caret at front of "456"
3) backspace once
observed results:
123456
expected results:
123
456
kin and i looked into this and the problem is in
nsHTMLEditRuels::WillDeleteSelection(), where a br node is being "joined" to a
text node (!). I need to add checks there to make sure we only join nodes if
both are text.
|
Assignee | |
Comment 1•24 years ago
|
||
high priority 098 - fix coming soon
Severity: normal → critical
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.8
|
|
Assignee | |
Comment 2•24 years ago
|
||
this should fix the problem, both in the backspace and forward delete case.
kin, sr?
Comment on attachment 64208 [details] [diff] [review]
patch to editor/libedtor/html/nsHTMLEditRules.cpp
sr=kin@netscape.com
Do we want to add an XXX comment stating that we may want to merge same
containers too? (ex 2 adjacent <b>s)
Attachment #64208 -
Flags: superreview+
|
|
Assignee | |
Comment 4•24 years ago
|
||
it's in the hole!!!!! (translation: fix landed on trunk)
Kin, I added comments to 36245 about merging inlines.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•