119109 - Keyboard shortcuts not working

Status: VERIFIED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Morten Nilsen]

pressing ctrl-t while browser (anywhere) has focus does nothing.
neither does 'n' in mailnews, ctrl-n in browser and so on.

Comment 1

[Kunihiko Aizawa]

On warpzilla 2002010911,
ctrl-t works as "reload" instead of ctrl-r,
ctrl-s works as "close tab" instead of ctrl-w,
ctrl-a still works fine...

Comment 2

[Hixie (not reading bugmail)]

Marking as smoketest blocker per #mozilla.

Comment 3

[Gilles Durys]

*** Bug 119129 has been marked as a duplicate of this bug. ***

Comment 4

[Hixie (not reading bugmail)]

Ctrl+End in the mail compose plain text editor opens the browser instead of
movign the cursor.

Comment 5

[Hixie (not reading bugmail)]

In the mailnews message list pane, the arrow keys are acting like the space bar.

In mail compose, Ctrl+N is acting like the arrow keys.

Comment 6

[jag (Peter Annema)]

harish, we screwed up, but it's pretty simple to fix...

@@ -1018,9 +1017,8 @@
     nsMemory::Free(str);
   }
 
-  nsAutoString key;
-  if (!aCharCode) {
-    aCharCode = &key;
+  nsAutoString key(aCharCode);
+  if (key.IsEmpty()) {
     if (mType == NS_HANDLER_TYPE_XUL) {
       mHandlerElement->GetAttr(kNameSpaceID_None, nsXBLAtoms::key, key);
       if (key.IsEmpty()) 

Here you're doing the switch from using |aCharCode| as your working string to |key|.

@@ -1028,8 +1026,8 @@
     }
   }
 
-  if (!(*aCharCode).IsEmpty()) {
-    nsAutoString charCode(*aCharCode);
+  if (!key.IsEmpty()) {
+    nsAutoString charCode(aCharCode);
     if ((mKeyMask & cShift) != 0)
       ToUpperCase(charCode);
     else

Then you correctly make that switch in the test (|!key.IsEmpty()|) but don't
make that switch in the assignment into |charCode| on the next line.

Fix is:

-    nsAutoString charCode(aCharCode);
+    nsAutoString charCode(key);

Except I've optimized |charCode| away and am using |key| straight. See patch.

Comment 7

[jag (Peter Annema)]

Attachment: Fix

Comment 8

[Peter Van der Beken [:peterv]]

Comment on attachment 64277 [details] [diff] [review]
Fix

Woohoo for Peter (the other one)! r=peterv.

Comment 9

[jag (Peter Annema)]

Checked in.

Comment 10

[Olav Vitters]

*** Bug 119171 has been marked as a duplicate of this bug. ***

Comment 11

[Olav Vitters]

*** Bug 119196 has been marked as a duplicate of this bug. ***

Comment 12

[Gilles Durys]

*** Bug 119213 has been marked as a duplicate of this bug. ***

Comment 13

[Matthias Versen [:Matti]]

*** Bug 119224 has been marked as a duplicate of this bug. ***

Comment 14

[Peter Van der Beken [:peterv]]

*** Bug 119227 has been marked as a duplicate of this bug. ***

Comment 15

[Olav Vitters]

*** Bug 119235 has been marked as a duplicate of this bug. ***

Comment 16

[Matthias Versen [:Matti]]

*** Bug 119248 has been marked as a duplicate of this bug. ***

Comment 17

[david avery]

re-opening - keyboard shortcuts still horked in 2002011003 builds

Comment 18

[david avery]

still asleep - 2002011009 builds fixed

Comment 19

[Olav Vitters]

*** Bug 119281 has been marked as a duplicate of this bug. ***

Comment 20

[Olav Vitters]

*** Bug 119282 has been marked as a duplicate of this bug. ***

Comment 21

[Olav Vitters]

*** Bug 119269 has been marked as a duplicate of this bug. ***

Comment 22

[Boris Zbarsky [:bzbarsky]]

*** Bug 119127 has been marked as a duplicate of this bug. ***

Comment 23

[Morten Nilsen]

verified by me and daa
reopen if needed.

Comment 24

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 119315 has been marked as a duplicate of this bug. ***

Comment 25

[K Chayka]

Just downloaded and installed win32 talkback build that's in /latest-trunk/:

mozilla-win32-talkback.zip   10-Jan-2002 13:01   9.7M 

Keyboard shortcuts still don't work.  Did the fix not get into today's win build?

Comment 26

[Matt Seitz]

The following worked for me:
/pub/mozilla/nightly/latest
mozilla-win32-installer.exe 10-Jan-2002 13:00   209k 
Mozilla.exe 349,664 bytes

Comment 27

[Sébastien Delahaye]

The one from 2002-01-10-12-trunk/ is
more recent. It now (re)works fine for me (w2k).

Comment 28

[Matthias Versen [:Matti]]

*** Bug 119393 has been marked as a duplicate of this bug. ***

Comment 29

[Olav Vitters]

*** Bug 119538 has been marked as a duplicate of this bug. ***