119117 - nsDiskCacheMap.h(250) : warning C4244: 'return' : conversion from 'unsigned char', possible loss of data

Status: RESOLVED FIXED

(Core :: Networking: Cache, defect)

Description

[timeless]

you're converting from a 16bit thing to a 8bit thing, and you're using 0 as 
magic.

0x00010000 would result in 0.  please fix.

Comment 1

[gordon]

There's no dataloss because we're just masking off the low 8 bits, but the
functions should really be returning PRUint8.  Here's the patch:

Index: mozilla/netwerk/cache/src/nsDiskCacheMap.h
===================================================================
RCS file: /cvsroot/mozilla/netwerk/cache/src/nsDiskCacheMap.h,v
retrieving revision 1.7
diff -u -2 -r1.7 nsDiskCacheMap.h
--- mozilla/netwerk/cache/src/nsDiskCacheMap.h	4 Jul 2001 07:06:34 -0000	1.7
+++ mozilla/netwerk/cache/src/nsDiskCacheMap.h	24 Jan 2002 01:07:29 -0000
@@ -168,5 +168,5 @@
     }
 
-    PRUint16   DataFileGeneration() const
+    PRUint8   DataFileGeneration() const
     {
         return (mDataLocation & eFileGenerationMask);
@@ -231,5 +231,5 @@
     }
 
-    PRUint16   MetaFileGeneration() const
+    PRUint8   MetaFileGeneration() const
     {
         return (mMetaLocation & eFileGenerationMask);

Comment 2

[Darin Fisher]

sr=darin (looks good)

Comment 3

[gordon]

patch checked in. Marking FIXED.