Closed
Bug 119447
Opened 24 years ago
Closed 13 years ago
[CSS] Composer should be able to unbold/unitalicize invalid markup
Categories
(SeaMonkey :: Composer, defect, P2)
SeaMonkey
Composer
Tracking
(Not tracked)
RESOLVED
WORKSFORME
mozilla1.1alpha
People
(Reporter: glazou, Unassigned)
References
Details
(Keywords: topembed+, Whiteboard: EDITORBASE+ 1 day [msword])
Attachments
(2 files)
|
489 bytes,
text/html
|
Details | |
|
7.03 KB,
patch
|
mozeditor
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
Composer, in CSS mode, should be able to unbold or remove italic font style
even if the markup is invalid, for instance if a B contains a P.
|
Reporter | |
Comment 1•24 years ago
|
||
This bug helping the editing of html documents exported by Microsoft products
with invalid markup, I am setting P2 098. Also setting nsDogFood keyword given
the fact the Focal Review html form contains this kind of invalid markup.
Setting EDITORBASE 1 day.
Status: NEW → ASSIGNED
Keywords: nsdogfood
Priority: -- → P2
Whiteboard: EDITORBASE 1 day
Target Milestone: --- → mozilla0.9.8
|
|
Reporter | |
Comment 2•24 years ago
|
||
1. launch composer in CSS mode
2. open test case
3. select "BBBBB"
4. click on the B button (resp. the I button)
expected result : "BBBBB" gets normal font weight (resp. roman font style)
5. select "inside"
6. click on B button
expected result : "inside" gets normal font weight
|
|
Reporter | |
Comment 3•24 years ago
|
||
Patch for this bug; Joe and Kin, can you review please ?
|
||
Comment 4•24 years ago
|
||
Should the comment that says:
// the parent has the style we want to apply and we are not trying to remove this
style
instead read:
// the parent has the style we want to apply and we *are* trying to remove this
style
??
Looks good otherwise.
|
|
||
Comment 5•24 years ago
|
||
Comment on attachment 64486 [details] [diff] [review]
patch v1.0
r=jfrancis
Attachment #64486 -
Flags: review+
Attachment #64486 -
Flags: superreview+
|
|
Reporter | |
Comment 7•24 years ago
|
||
Joe: no, no, my comment is ok. See the ! in the test.
|
|
Reporter | |
Comment 8•24 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Comment 9•24 years ago
|
||
back out authorization requested from drivers
|
||
Comment 10•24 years ago
|
||
a=asa (on behalf of drivers) for checkin of backout.
Keywords: mozilla0.9.8+
|
|
Reporter | |
Comment 11•24 years ago
|
||
Backed out (thanks a lot Asa, this was really needed) and reopened.
See reasons why in bug 120377.
Removing mozilla0.9.8+ so things are less confusing for drivers trying to manage
bug lists, since the bug is reopened but the reason it was + is fixed.
Keywords: mozilla0.9.8+
|
|
Reporter | |
Comment 13•24 years ago
|
||
=> 099
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.8 → mozilla0.9.9
|
|
||
Comment 14•24 years ago
|
||
minusing because we should focus on valid content, or content generated by us
(which outta be valid)
Whiteboard: EDITORBASE 1 day → EDITORBASE- 1 day
|
|
||
Comment 16•24 years ago
|
||
removing myself from the cc list
|
|
||
Comment 17•23 years ago
|
||
EDITORBASE+, msword compatibility
Whiteboard: EDITORBASE- 1 day → EDITORBASE+ 1 day [msword]
|
|
||
Updated•23 years ago
|
QA Contact: sujay → sairuh
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
|
||
Comment 19•18 years ago
|
||
Daniel,
Are you still working on this ?
|
||
Comment 20•13 years ago
|
||
On testcase in Comment 2 i get both Bold styles removed when pressing B button, so looks like WFM
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0 SeaMonkey/2.13a1
Build identifier: 20120712003002
Assignee: daniel → nobody
Status: ASSIGNED → RESOLVED
Closed: 24 years ago → 13 years ago
QA Contact: bugzilla
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•