1196157 - Marks left by performance marks should print the domain of the application and not the complete URL

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Description

[Salvador de la Puente González [:salva]]

Follow up of bug 1186880. Marks left by performance API in workers should follow the same pattern as in the main thread.

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Obtaining the host for the worker script to include into the performance marks

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8649786 [details] [diff] [review]
Obtaining the host for the worker script to include into the performance marks

Review of attachment 8649786 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/Performance.cpp
@@ +66,5 @@
>  
>  void
>  Performance::InsertUserEntry(PerformanceEntry* aEntry)
>  {
> +  nsAutoCString uri;

move it into the next if()

@@ +71,2 @@
>    if (mWorkerPrivate->PerformanceLoggingEnabled()) {
> +    nsresult rv = mWorkerPrivate->GetResolvedScriptURI()->GetHost(uri);

what about if GetResolvedScriptURI returns nullptr?
I would do:

nsAutoCString uri;
nsCOMPtr<nsIURI> scriptURI = mWorkerPrivate->GetResolvedScriptURI();
if (!scriptURI || NS_FAILED(scriptURI->GetHost(uri)) {
  // If we have no URI, just put in "none".
  uri = AssignLiteral("none");
}
...

Comment 3

[Salvador de la Puente González [:salva]]

Attachment: Obtaining the host for the worker script to include into the performance marks.v2

Patch updated. :baku, do you mind to review it again? Thank you!

Comment 4

[Salvador de la Puente González [:salva]]

Push in treeherder: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7515298241c

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/33c6251f05cf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/33c6251f05cf