119625 - Can't enter new bug or post comments (POSTs turn into GETs)

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Hixie (not reading bugmail)]

With a CVS tip build, I cannot post new bugs or comment on new bugs. On 
IRC choess reports that this is because POSTs are being turned into GETs 
with no arguments:

<choess> what I see:
<choess> "GET /cgi-bin/buildchron.cgi HTTP/1.1" 200 2688
<choess> "Content-type: application/x-www-form-urlencoded" 400 -
<choess> what I should see:
<choess> "POST /cgi-bin/buildchron.cgi HTTP/1.1" 200 774

See http://www.mozilla.gr.jp:4321/ for a debug server for this.

Comment 1

[R.K.Aa.]

saw what's probably the same with a cvs build including checkins through
01/11/2002 15:02 ("bonsai time")

Trying to post comments in bugzilla only returns:
"Error
 you did no select any bugs to modify"

Comment 2

[R.K.Aa.]

backing out the checkins for bug 112479 fixes this:

cvs update -j1.19 -j1.18 mozilla/netwerk/protocol/http/src/nsHttpTransaction.h
cvs update -j1.41 -j1.40 mozilla/netwerk/protocol/http/src/nsHttpTransaction.cpp
cvs update -j1.14 -j1.13 mozilla/netwerk/protocol/http/src/nsHttpResponseHead.h
cvs update -j1.19 -j1.18 mozilla/netwerk/protocol/http/src/nsHttpChannel.h
cvs update -j1.78 -j1.77 mozilla/netwerk/protocol/http/src/nsHttpChannel.cpp

CC darin

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

->darin

Comment 4

[Bradley Baetz (:bbaetz)]

From bug 112479:

"------- Additional Comment #9 From Christophe Fergeau 2002-01-12 12:38 -------

In nsHttpChannel::SetUploadStream, it seems that the line
mUploadStream = stream;
should be at the beginning at the function, not at the end.
The old code was first initialising mUploadStream, and bug #119625 doesn't seem
to occur with that line moved.
I don't understand this code at all, so I'm sorry if I'm telling stupid things :)
"

Looking at the code, this is indeed correct - else mUploadStream (which is an
nsCOMPtr, and so is inited to null), and so we always send a GET.

I'll test this, then attach a patch

Comment 5

[Bradley Baetz (:bbaetz)]

Yeah, that fixes it. I still get:

###!!! ASSERTION: NS_ENSURE_TRUE((NS_SUCCEEDED(result) && !stateKey.IsEmpty()))
failed: '((!((result) & 0x80000000)) && !stateKey.IsEmpty())', file
/home/bbaetz/src/mozilla/content/html/content/src/nsGenericHTMLElement.cpp, line
2833
###!!! Break: at file
/home/bbaetz/src/mozilla/content/html/content/src/nsGenericHTMLElement.cpp, line
2833

Was this happening before? I haven't run CVS for a few weeks.

Comment 6

[Bradley Baetz (:bbaetz)]

Attachment: patch

Patch by [e-mail]

Comment 7

[Bradley Baetz (:bbaetz)]

Comment on attachment 64689 [details] [diff] [review]
patch

r=bbaetz

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 64689 [details] [diff] [review]
patch

sr=[e-mail]

Comment 9

[Bradley Baetz (:bbaetz)]

Checked in, thanks

Comment 10

[Bradley Baetz (:bbaetz)]

*** Bug 119742 has been marked as a duplicate of this bug. ***

Comment 11

[Darin Fisher]

thanks for fixing this bug in my checkin.  i meant to assign mUploadStream at
the end of the function because in the error case, the state of the http channel
should not change.  the problem with my checkin was that the first if () block
should have been checking if (stream), and not if (mUploadStream).  my bad for
not running this through the usual tests :-(

i'm reopening this in order to attach the intended patch.

Comment 12

[Darin Fisher]

Attachment: patch - what was originally intended

Comment 13

[Bradley Baetz (:bbaetz)]

Comment on attachment 64877 [details] [diff] [review]
patch - what was originally intended

fair enough. r=bbaetz

Comment 14

[Alec Flett]

Comment on attachment 64877 [details] [diff] [review]
patch - what was originally intended

sr=alecf

Comment 15

[Darin Fisher]

fixed-on-trunk

Comment 16

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 120002 has been marked as a duplicate of this bug. ***

Comment 17

[Vladimir Ermakov]

verifying on build 2002-01-28-08-trunk