119796 - Last Visited bookmark field always displays blank

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[Luke Koleszar]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:0.9.7+) Gecko/20020111
BuildID:    2002011103

Sometime around Jan. 3, the Last Visited bookmark field stopped working.

Reproducible: Always
Steps to Reproduce:
1. Open Manage Bookmarks window
2. Turn on "Last Visited" display


Actual Results:  Notice that all bookmarks have a blank Last Visited field

Expected Results:  Last Visited field shows the time and date that the page was
last visited.

Works with 0.9.7
Works with 2002010303

Doesn't work with 2002010403
Doesn't work with 2002011103

Comment 1

[Luke Koleszar]

Note that the Last Visited time is remembered correctly with current builds. 
This seems to be only a display problem.

I.E. if you visit a bookmark with 2002011103, then run 0.9.7, the Last Visited
time does correctly reflect the visit just made in 2002011103.

Comment 2

[Asa Dotzler [:asa]]

This worked fine in previous releases. It appears that the backend is still
functioning so this shouldn't be too difficult to explore and fix. If we don't
fix this then the column should be removed from the Bookmarks Manager for the
next major releases. 

Comment 3

[Peter Trudelle]

nsbeta1- per Nav triage team,  ->1.2

Comment 4

[Nahor]

Actually, the "last visited" field is displayed in the "added" column.

Comment 5

[Jean-Pierre Melkonian]

Same thing with Mac OS 9.1 Build 2002061103

Comment 6

[Michael Gabriel]

confirming comment #4 "last visited" content appears in "added" field, should be
very easy to fix now

Comment 7

[slipszi]

Attachment: Patch to fix the bug

Added a patch to fix the bug and to display the last modified date correctly as
well.

Comment 8

[Michael Gabriel]

just for the notes:
this bug needs a new traget ...
the bug lies not within the viewer
the data is saved to the wrong field in bookmarks.html

Comment 9

[slipszi]

> this bug needs a new traget ...

Agreed. Since this is a trivial fix, perhaps it could be mozilla1.2beta? Well, I 
guess it really depends on when will Ben have time for this.

> the bug lies not within the viewer
> the data is saved to the wrong field in bookmarks.html

No, the problem *is* with the viewer:

1. The order of the columns in the column definition of the bookmark tree is not 
the same as the order of cells in the body of the tree
2. The label of the Last Modified Date has changed from NC-rdf to WEB-rdf, but 
bookmarks.xml still uses NC-rdf

These two errors are corrected in the patch that is attached to this bug.

Comment 10

[slipszi]

Attachment: Updated patch to fix the bug

Updated patch for the latest version (1.47) in the trunk

Comment 11

[Christian :Biesinger (don't email me, ping me on IRC)]

try asking the review of a specific person, I think jag
([e-mail]) would be good for fixes in this area.

Comment 12

[Chris Lyon]

*** Bug 193920 has been marked as a duplicate of this bug. ***

Comment 13

[Chris Lyon]

*** Bug 146534 has been marked as a duplicate of this bug. ***

Comment 14

[Matthias Versen [:Matti]]

*** Bug 197609 has been marked as a duplicate of this bug. ***

Comment 15

[Jan Varga [:janv]]

*** This bug has been marked as a duplicate of 124819 ***

Comment 16

[Jan Varga [:janv]]

sorry, I haven't noticed thar there is a patch attached.
Can I take it and check into the bookmarks branch ?

Comment 17

[slipszi]

Attachment: Patch diffed against the latest tree

Althogh the patch is trivial, I still do not have r= or sr= for it. If you can
check it in anyway, please, do it.

Comment 18

[Jan Varga [:janv]]

sorry for not letting you know, this is already fixed on the branch we are
working on, so you don't have to request a review for this.

Comment 19

[Jan Varga [:janv]]

reopening, since this bug has a patch

Comment 20

[Jan Varga [:janv]]

-> Silvester

Comment 21

[Chris Petersen]

Using the 2003-03-25-03 Mach0 and 2003-03-25-04 Win32 trunk builds, The last
visited  field is now providing the correct time on when that bookmark was
previously loaded.

Comment 22

[Jan Varga [:janv]]

I probably caused a confusion here. This is fixed on the trunk by big bookmarks
landing on Monday.

Comment 23

[Chris Petersen]

OK, this looks fine now. Marking verified.

Comment 24

[Alec Flett]

Comment on attachment 117535 [details] [diff] [review]
Patch diffed against the latest tree

ooh, that's easy. sr=alecf

Comment 25

[Chris Petersen]

Verified.