120018 - Pressing ESC in Delete Profile dialog gives unexpected results

Status: VERIFIED FIXED

(SeaMonkey :: Startup & Profiles, defect)

Description

[Robert John Churchill]

If I open up the Profile Management window, select a user profile, and click the
"Delete Profile" button, a dialog pops up with some text describing what's about
to happen along with three options for the question of whether I want to delete
the profile's data files:

o Cancel
o Delete Files
o Don't Delete Files  <-- the default if I press RETURN

However, if I press the ESC key on the keyboard, the "Delete Files" option is
chosen instead of cancelling the operation (which is what I'd expect).

This has caused data loss for me wherein a profile's contents are deleted when I
didn't expect them to be!

Comment 1

[Conrad Carlen (not reading bugmail)]

It's a standard nsIPromptService dialog (same as Save/Don't Save/Cancel) but the
buttons are in the wrong order. I'll take it.

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: Patch which makes "Cancel" be button triggered by Esc

Yep. Cancel was in the wrong slot so the escape key triggered the wrong button
(ouch!) Reviews please - I'd like to get this into 0.9.8 since it's such deadly
dataloss.

Comment 3

[Conrad Carlen (not reading bugmail)]

updating summary

Comment 4

[Robert John Churchill]

Comment on attachment 65310 [details] [diff] [review]
Patch which makes "Cancel" be button triggered by Esc

r=rjc

Comment 5

[Conrad Carlen (not reading bugmail)]

CC'ing Alec for sr.

Comment 6

[Alec Flett]

Comment on attachment 65310 [details] [diff] [review]
Patch which makes "Cancel" be button triggered by Esc

sr=alecf

Comment 7

[Conrad Carlen (not reading bugmail)]

-> 0.9.8, asking drivers

Comment 8

[Christopher Blizzard (:blizzard)]

Oy.  a=blizzard on behalf of drivers for 0.9.8.

Comment 9

[Conrad Carlen (not reading bugmail)]

Checked in.

Comment 10

[K'Trina Medina]

Verified code fix. I was going to try to reproduce this but I want to keep my
profile's contents. Please reopen if this problem reoccurs.