Closed Bug 120504 Opened 24 years ago Closed 24 years ago

QI'ing an nsGenericElement based element to nsIDOM* ends up in the binding manager code...

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla0.9.9

People

(Reporter: jst, Assigned: jst)

Details

(Keywords: perf, Whiteboard: [HAVE FIX])

Attachments

(1 file)

When QI'ing an nsGenericElement based element to nsIDOM* we end up asking the binding manager if there's a binding available that implements the nsIDOM* interface before we check if the element itself implements that interface. Patch coming up.
Oh, this patch also fixes a potential range list leak.
Comment on attachment 65396 [details] [diff] [review] Don't ask the binding manager if there's a binding that implements an interface before we know if the we implement it ourselves. r/sr=brendan@mozilla.org
Attachment #65396 - Flags: review+
Thanks brendan. hyatt, would you r= or sr=?
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P2
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.9
Attachment #65396 - Flags: superreview+
Hyatt says r=hyatt.
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: