Closed
Bug 120504
Opened 24 years ago
Closed 24 years ago
QI'ing an nsGenericElement based element to nsIDOM* ends up in the binding manager code...
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: jst, Assigned: jst)
Details
(Keywords: perf, Whiteboard: [HAVE FIX])
Attachments
(1 file)
When QI'ing an nsGenericElement based element to nsIDOM* we end up asking the
binding manager if there's a binding available that implements the nsIDOM*
interface before we check if the element itself implements that interface. Patch
coming up.
Assignee | ||
Comment 1•24 years ago
|
||
Assignee | ||
Comment 2•24 years ago
|
||
Oh, this patch also fixes a potential range list leak.
![]() |
||
Comment 3•24 years ago
|
||
Comment on attachment 65396 [details] [diff] [review]
Don't ask the binding manager if there's a binding that implements an interface before we know if the we implement it ourselves.
r/sr=brendan@mozilla.org
Attachment #65396 -
Flags: review+
Assignee | ||
Comment 4•24 years ago
|
||
Thanks brendan. hyatt, would you r= or sr=?
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P2
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.9
![]() |
||
Updated•24 years ago
|
Attachment #65396 -
Flags: superreview+
Assignee | ||
Comment 5•24 years ago
|
||
Hyatt says r=hyatt.
Assignee | ||
Comment 6•24 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: DOM: Core → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•