120607 - nsGenericHTMLElement::HasAttribute() sometimes returns false when attribute exists

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Charles Manske]

Using "element.hasAttribute()" on an element in a document being edited is
always returning false when I know it exists. In JS code, foo.getAttribute()
returns a 
value and foo.attributes.getNamedItem() correctly returns an attribute node.
I'll attach a test file.

Comment 1

[Charles Manske]

Attachment: Test file to show that hasAttribute("src") fails, when the image obviously has a valid src URL.

This test succeeds in NS 6.2.1

Comment 2

[Charles Manske]

This problem would seem rather critical!

Comment 3

[Charles Manske]

I did some debugging and find that some attributes do succeed: E.g., if I have
an "img" with "width", "height", and "alt" set, the "width" and "height" are 
found by FindHTMLAttribute(), but "src" and "alt" are not.
The search for attributes starts with "mFirst". Could this be wrong?
cc'ing Hewitt, since he wrote nsHTMLMappedAttributes::GetAttribute().

Comment 4

[Charles Manske]

Note that the test file seems to succeed in NS 6.2.1 because "HasAttribute()"
wasn't implemented! So that fact is irrelevant.
Since Hewitt implemented this stuff recently (12/10/01), reassigning to him.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Not all attributes are mapped attributes.  Mapped ones worked fine with the
existing code, non-mapped ones broke.

Comment 6

[Boris Zbarsky [:bzbarsky]]

reviews?

Comment 7

[Charles Manske]

Attachment: Another version, somewhat simpler

I just figured out the same thing!

Comment 8

[Charles Manske]

Comment on attachment 65466 [details] [diff] [review]
Another version, somewhat simpler

darn, attached wrong diff! line should be:
+  if (mMapped && mMapped->HasAttribute(aAttrName))

of course! (no ";")

Comment 9

[Boris Zbarsky [:bzbarsky]]

That works too.  :)

jst, is there a function that takes and nsIAtom and quickly says "mapped" or
"not mapped" so that we can avoid doing FindHTMLAttribute for mapped attributes
that are note set?

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 65466 [details] [diff] [review]
Another version, somewhat simpler

Whether or not an attribute is mapped or not depends on the element, so there
is no such method AFAIK.

sr=jst

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 65466 [details] [diff] [review]
Another version, somewhat simpler

Ok, then.  r=bzbarsky

Comment 12

[Charles Manske]

Thanks for reviews. Should we check this in for 0.9.8? (I'll ask drivers for that)

Comment 13

[Sivakiran Tummala]

this testcases passed in 6.2.1 RTM, it is a regression from Gecko/20011128

Comment 14

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.8

Comment 15

[Asa Dotzler [:asa]]

I saw a checkin comment referencing this bug: "01/18/2002
12:08cmanske%netscape.com mozilla/ content/ html/ style/ src/
nsHTMLAttributes.cpp 3.66 2/2  Fixed hasAttribute for non-mapped attributes,
b=120607, r=[e-mail], sr=jst, a=blizzard/drivers"

Is it resolved? If so, can you mark it Fixed to pull it from the "0.9.8
outstanding" list? Thanks.

Comment 16

[Charles Manske]

checked in.

Comment 17

[Sivakiran Tummala]

verified fixed. build 2002-01-25-08