Closed
Bug 120833
Opened 24 years ago
Closed 24 years ago
default value of nsICacheEntryInfo::expirationTime should be -1
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: darin.moz, Assigned: gordon)
Details
(Keywords: arch)
Attachments
(1 file)
|
4.07 KB,
patch
|
gagan
:
review+
darin.moz
:
superreview+
|
Details | Diff | Splinter Review |
instead of using 0 to indicate an infinite expiration time, i think it would be
better to use -1.
i made the mistake of thinking an expiration time of 0 meant the same thing as a
0 freshness lifetime. fortunately i caught the mistake before checking in the
code, but i'm concerned that others might make the same mistake.
|
Reporter | |
Updated•24 years ago
|
Keywords: arch,
mozilla0.9.9
Comment on attachment 66224 [details] [diff] [review]
patch to change default expiration time to MAX LONGINT.
suggest changing the enum to #define cuz it is in global namespace. with that
r=gagan
Attachment #66224 -
Flags: review+
|
|
Reporter | |
Comment 3•24 years ago
|
||
Comment on attachment 66224 [details] [diff] [review]
patch to change default expiration time to MAX LONGINT.
please fix nsHttpChannel::UpdateExpirationTime as well.
sr=darin
Attachment #66224 -
Flags: superreview+
patch with corrections checked in. Marking FIXED.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•