121253 - need to port gtkmozembed to gtk2

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GTK Widget, defect)

Description

[Christopher Blizzard (:blizzard)]

Need to port gtkmozembed to gtk2.

Comment 1

[Jorn Baayen]

Attachment: patch to make it compile with gtk2 - not sure whether it works

Comment 2

[Christopher Blizzard (:blizzard)]

Just FYI, I do have a building copy as well in a local tree that is a lot
cleaner than that patch.  I just need finish it up.  It will happen in the next
week to week and a half.

Comment 3

[Jorn Baayen]

How is the port doing?

Comment 4

[Marco Pesenti Gritti]

Chris, any chance to get your patches in for mozilla 1.2 ?
That code, along with bug 144212 patch, appear to work already very well. No
crashes neither critical issues.

Comment 5

[Jay Yan]

Chris:

I recall that you have patch for it, any plan to upload that here? thanks.

-Jay

Comment 6

[Christopher Blizzard (:blizzard)]

I should have something to upload by the end of the day.  I'm bringing my gtk2
tree back into shape as we speak.

Comment 7

[Christopher Blizzard (:blizzard)]

Still working on this.

Comment 8

[Christopher Blizzard (:blizzard)]

Attachment: patch

This patch should work and compile with both gtk2 and gtk 1.2, shouldn't cause
any regressions to the 1.2 code.  I can't find any obvious problems with the
embedding widget in either port with this patch.

Comment 9

[Marco Pesenti Gritti]

Looking at the patch I'd guess the crash reported in bug 144212 is still 
happening. I cant test it before Friday though :(

To have a fully functional gtkmozembed we need also to address 162507. (Yeah I 
know this is only slightly related to this bug).
Thanks to be working on this !

Comment 10

[Christophe Fergeau]

I haven't tested the new patch, but bug #156093 probably still happens with this
patch.

Comment 11

[Tommi Komulainen]

Attachment: Fix build errors with --disable-accessibility

This patch should fix build errors that occur because
nsAccessibilityInterface.cpp is being built even if --disable-accessibility
configuration option is used.

Comment 12

[Tommi Komulainen]

With the current patch, build fails on TestGtkEmbed because it's being linked
against gtksuperwin, which doesn't exist for gtk2 build; proper ifdefs are
missing from the Makefile.in.

Comment 13

[Tommi Komulainen]

Attachment: Fix TestGtkEmbed build errors

This patch sets the LIBS depending on whether gtk1 or gtk2 is used.  Works at
least with gtk2, but I don't see why it wouldn't work with gtk1 as well.

Comment 14

[Christopher Blizzard (:blizzard)]

Comment on attachment 103966 [details] [diff] [review]
Fix build errors with --disable-accessibility

please open a new bug and put this patch in it since it's not strictly
embedding-related

Comment 15

[Tommi Komulainen]

The mozilla-gtkmozembed.pc that's generated for gtk2 build also falsely includes
the -lgtksuperwin option.  This makes building eg. galeon fail.

Comment 16

[John M]

What is happening with this bug? This is by far the most important bug
when it comes to gtk2.

Comment 17

[Christopher Blizzard (:blizzard)]

I'll start working on this again on Thursday when I return from being out of
town at offsite meetings.  Relax.

Comment 18

[Christopher Blizzard (:blizzard)]

Attachment: patch

updated patch

Comment 19

[Christopher Blizzard (:blizzard)]

The latest patch here compiles with gtk2 and gtk1.2 and doesn't seem to cause
any regressions to the 1.2 code.  It's also got a couple of other patches rolled
up into it.

Comment 20

[Christopher Blizzard (:blizzard)]

Comment on attachment 106446 [details] [diff] [review]
patch

I'm going to assume this is sr=bryner as well.

Comment 21

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks!

Comment 22

[Christopher Blizzard (:blizzard)]

-> fixed