121440 - Mac OS X native theme scrollbar arrows not painted correctly

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect, P1)

Description

[Adam Lock]

Observed on Mac OS X with a trunk pull & build from 23 Jan:

1. Set the theme to classic so native style scrollbars are rendered.
2. Load a URL into the browser and shrink the window until horizontal and
vertical scrollbars are visible.
3. Scroll the image by clicking on the up/down arrows on the vertical scrollbar
and the left/right arrows on the horizontal one. 

Result:

Arrows are not correctly highlighted when depressed. The only one that is
highlighted is the down arrow and that sometimes renders a a pixel off from
where it should be causing a jiggling effect. Same behaviour is observed whether
the system prefs are set so that arrows are rendered at either end of the bar or
 grouped together.

Comment 1

[jag (Peter Annema)]

-> Themes

Comment 2

[Mike Pinkerton (not reading bugmail)]

yeah yeah i know.

hyatt, the current scheme for scrollbars just isn't going to work on mac since
we can only draw the entire bar. we're gonna have to come up with something like
a single frame with no anon content.

Comment 3

[Adam Lock]

The APIs say there is a DrawThemeScrollBarArrows function for this purpose. I
noticed a comment in nsNativeThemeMac that says this is a no-op - is that really
true?

Comment 4

[Mike Pinkerton (not reading bugmail)]

yes, it is really true. I asked apple. DrawThemeScrollBarArrows is a no-op in aqua.

Comment 5

[Mike Pinkerton (not reading bugmail)]

this will go away as part of the rewrite for 115758

Comment 6

[Mike Pinkerton (not reading bugmail)]

Attachment: use native scrollbars instead

this patch guts xbl scrollbars in classic and replaces them with native ones,
specified via XBL. the mechanism to do native scrollbars from within the gfx
scrollview is XP, but currently only implemented on macos.

needing r/sr.

Comment 7

[Mike Pinkerton (not reading bugmail)]

smfr wanted to be cc'd. also could use the sr.

Comment 8

[Mike Pinkerton (not reading bugmail)]

Attachment: updated patch with all the files

i forgot most of the makefile changes in the first patch. also detabbed a
couple files and switched from NPL to MPL on new files.

Comment 9

[Steve Dagley]

Comment on attachment 76102 [details] [diff] [review]
updated patch with all the files

r=sdagley

Comment 10

[Patrick C. Beard]

Comment on attachment 76102 [details] [diff] [review]
updated patch with all the files

Nit, don't introduce a new mRefCnt field in nsNativeScrollbar if you can help
it.
sr=beard

Comment 11

[Patrick C. Beard]

Comment on attachment 76102 [details] [diff] [review]
updated patch with all the files

Nit, don't introduce a new mRefCnt field in nsNativeScrollbar if you can help
it.
sr=beard

Comment 12

[Mike Pinkerton (not reading bugmail)]

yay! fixed