121730 - Add number of entries actually removed from sHistory when using PurgeHistory()

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[David Epstein]

currently, PurgeHistory() takes a request for number of entries to be removed
from session history. But if the notification is set to false for the purge
history listener, there is nothing passed back to PurgeHistory() to indicate
that no entries were removed. The user only gets a message that x number of
entries were requested for removal.

To see this:
1) Set notification to PR_FALSE in nsISHistoryListener::OnHistoryPurge(). In
TestEmbed, it's in BrowserImplHistoryLstnr.cpp.
2) Compile and Run TestEmbed from bin directory.
3) From Test menu, add the history listener.
4) Enter a couple of urls.
5) From Interfaces > nsISHistory menu, select Purge History. 
Result: It will indicate 3 entries requested for removal from session history
(both from the history lstnr and PurgeHistory() methods).
Expected: Indicate that 0 entries were removed. A return variable would need to
be passed back to PurgeHistory(). So if the notification flag is TRUE, then it
would indicate 3 were removed.

Comment 1

[David Epstein]

This bug needs to be reassigned.

Comment 2

[timeless]

Attachment: provide indication that purgehistory was vetod

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 154959 [details] [diff] [review]
provide indication that purgehistory was vetod

Sure, this is reasonable.  r+sr=bzbarsky.

Comment 4

[timeless]

mozilla/xpfe/components/shistory/public/nsISHistory.idl 	1.14
mozilla/xpfe/components/shistory/src/nsSHistory.cpp 	1.65