121939 - New Page command doesn't work

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[Charles Manske]

This is a regression caused by moving "NewEditorPage()" method out of global
overlay files into editorApplicationOverlay.js (bug 89975)

Comment 1

[Charles Manske]

Must be fixed!

Comment 2

[Charles Manske]

Attachment: Fix

The basic fix is to include editorApplicationOverlay.js in the main editor XUL.

Other changes:
1. Renamed "overlay_editPage()" to "editDocument"
2. Removed comments concerning moving "editPage()", which was done.
3. Moved all editPage-related commands together in editorApplicationOverlay.js
Note that I didn't rename "editPage" to "editURL" as suggested in the comments;

we use "editPage" in the command name, keybinding text, etc, so it didn't
seem like a good idea to make that change.

Comment 3

[Charles Manske]

Attachment: Updated patch

removed junk that's not part of this fix

Comment 4

[Kathleen :Brade]

Comment on attachment 66555 [details] [diff] [review]
Updated patch

rs=brade

(although I don't understand why we need both editDocument and editPage (sounds
VERY confusing))

Comment 5

[Joe Hewitt (gone)]

Comment on attachment 66555 [details] [diff] [review]
Updated patch

sr=hewitt

Comment 6

[Charles Manske]

checked in.

Comment 7

[R.K.Aa.]

*** Bug 122294 has been marked as a duplicate of this bug. ***

Comment 8

[Charles Manske]

forgot to mark fixed!

Comment 9

[michael wendell]

Verified.