122067 - [mach] make in xpinstall/packager creates a tar.gz

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Marcus Pallinger]

running make (gmake) in xpinstall/packager creates a .tar.gz like any other unix
distribution. when this is untarred, there is no double clickable app.

Ideally it will create a disk image containing Mozilla.app (which isn't in the
tar file)

Comment 1

[hacker formerly known as [e-mail]]

Over to Zach as I know nothing about making diskimages for macho.

Comment 2

[Zach Lipton [:zach]]

well I know nothing about Makefiles and the packaging system so this will 
be fun... I'll see what I can do though. 

Comment 3

[Frankie]

This comment posted from 20030313 Mach-O.

Res ipsa loquitur.

Comment 4

[hacker formerly known as [e-mail]]

Umm, just because there are nightlies which create diskimages does not mean that
this bug is fixed.

Comment 5

[hacker formerly known as [e-mail]]

Attachment: v1.0

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 117312 [details] [diff] [review]
v1.0

why not use build/package/mac_osx/make-diskimage instead of duplicating it
here?

Comment 7

[hacker formerly known as [e-mail]]

Because I had no idea it existed in the mozilla tree.  I though it was stuffed
in the commercial tree somwhere.

Comment 8

[J.J. Enser]

I wasn't aware either of the existence of
mozilla/build/package/mac_osx/make-diskimage

The make-diskimage script I'm using for the nightly builds - that I inherited
from bryner about a month ago - has been revv'ed a couple of times since then,
and I was going to check it in the commercial tree together with the netscape
nightly build automation. But since is has nothing specific to netscape, I'll
update mozilla/build/package/mac_osx/make-diskimage instead with my changes
(added support for background image and a license dialog display on mount).

When that's done, you might be able to call it from Makefile.in as Brian suggests.

Comment 9

[hacker formerly known as [e-mail]]

Attachment: v1.1

Comment 10

[hacker formerly known as [e-mail]]

Patch has been checked in.