Closed Bug 12221 Opened 25 years ago Closed 25 years ago

[Dogfood] Gfx text controls need to notify on mouse events

Categories

(Core :: DOM: Selection, defect, P2)

Product:
Core
Component:
DOM: Selection
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: cpratt, Assigned: buster)

References

Details

(Whiteboard: [PDT ]) 

Build ID: 1999082008
Platform: all

To reproduce:

- Launch apprunner
- Select the URL displayed in the Location: control in this manner:

 -------------------------------------------------------------------
| http://www.yahoo.com *                                         ^  |
 -------------------------------------------------------------------

Pretend that my ASCII art represents the Location: control in the browser.

In legacy browsers, if you position the cursor at the caret (^), click and hold
the mouse button, and drag to the left, the entire URL will be selected.
However, this fails in apprunner. Instead, you have to position the cursor
immediately to the right of the URL (marked here by an asterix (*)). This is a
major usability problem.
Assignee: buster → mjudge
Priority: P3 → P2
Summary: Text selection in Location: control too sensitive → [Dogfood] Text selection in Location: control too sensitive
Target Milestone: M10
known problem, assigned to mike.
Status: NEW → ASSIGNED
pretty much done. tables still have an issue though. working on this. its a dup
of a feature for clicking in dead zones. will keep this alive until tables work.
*** Bug 4327 has been marked as a duplicate of this bug. ***
Blocks: 12658
In the build I have (25/08), there seems to be some problems with the current
implementation on some of the text in demo 0 & 1 (and maybe others).
Component: Editor → Selection
QA Contact: sujay → elig
Since this is a selection issue, QA Assigning to self, CC:ing Sujay, and changing
component.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
works now, or at least it should.
Status: RESOLVED → REOPENED
Summary: [Dogfood] Text selection in Location: control too sensitive → [Dogfood] Dead selection disallowed in Location: bar
Re-opening; it will not allow you to drag select from the ~10 pixel region to the
left of the URL text, despite displaying an i-beam. (1999091409 builds checked on
Mac OS & Win32, and 1999 09/13 build on Linux)
Resolution: FIXED → ---
Clearing FIXED resolution due to reopen of this bug.
Assignee: mjudge → kin
Status: REOPENED → NEW
Target Milestone: M10 → M12
m12; kin
Status: NEW → ASSIGNED
Accepting bug.
Assignee: kin → buster
Status: ASSIGNED → NEW
When you click on the edge of the location control (^), the button down event is
actually going to the GFXTextControlFrame which does nothing with it.

We need to add some sort of mouse listener, or some code to
GFXTextControlFrame::HandleEvent() that will forward on mouse events to the
inner presShell so that the text control's inner document can process it.

Reassigning to buster@netscape.com, the author of the GFXTextControlFrame code.
Added kin@netscape.com to the Cc list.
Status: NEW → ASSIGNED
Summary: [Dogfood] Dead selection disallowed in Location: bar → [Dogfood] Gfx text controls need to notify on mouse events
all the code is there, just commented out because mouse
notifications are non-standard behavior for HTML text controls.  But that
doesn't mean we can't use it internally.  Will turn it on as soon as the tree
opens.
Whiteboard: fix in hand
Putting on [PDT]+ radar.
Whiteboard: fix in hand → [PDT+]fix in hand
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+]fix in hand → [PDT ]
fixed
r=rods@netscape.com
also did some associated performance work, factoring code and collapsing
multiple listener objects down to 1.  This saves a few allocations and about 60
bytes per text control.
Status: RESOLVED → VERIFIED
Verified fixed on 1999102008 (Mac OS, 8.6), 1999101908 (Win32, NT 4.0SP5), and
1999101908 (Linux, RH 6.0/GNOME).

Specifically, performed the instructions detailed in the bug report, as well as
double- and triple-clicking.

----

I noticed a very small nitpick, in which clearing the URL entire text field (on
all platforms) and double-clicking in it will still result in the first character
being highlighted.

Since this doesn't occur on IE or Navigator, I'm going to write it up as a
formality, and will note the bug number here.
[Nitpick broken into 16905.]
You need to log in before you can comment on or make changes to this bug.