12242 - patched file deleted after patch, if registry call fails in finalize

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P3)

Description

[Cathleen]

if for some reason, your registry file (nsreg.dat) is corrupted, and you install
a patch to patch files, your files will all be deleted.

To reproduce (must have a corrupted registry):
1. trigger http://warp/u/cathleen/test/xpinstall/patch/install.jar to install a
file in c:\patch\f1.txt
2. trigger http://warp/u/cathleen/test/xpinstall/patch/patch.jar to patch f1.txt
3. noticed that nothing is left in c:\patch

We don't need to track the return value for VR_Install in
nsInstallPatch::Complete() because it will cause abort,and in turn the file gets
deleted.  Patching is not a reversible process, if the registry update fails, we
leave the patched/updated file.

Comment 1

[Cathleen]

I believe Dan has a simple fix for this on his machine.

Comment 2

[Cathleen]

Dan, you got the fixes on your machine.  Can you check them in?

Comment 3

[Jimmy Lee]

Build  1999-10-22-09-M11(WIN), 1999-10-21-09-M11(MAC), 1999-10-22-08-M11(LINUX)

Files patch even if they can't get registered.  Marking Verified.

Comment 4

[leger]

Bulk move of XPInstall (component to be deleted) bugs to Installer: XPInstall
Engine