122438 - ConvertContractIDKeyToString(...) optimization.

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Doug Turner (:dougt)]

Why does ConvertContractIDKeyToString(...) in nsComponentManager.cpp create
an intermediate 'nCAutoString' ??

+    const char *contractID = entry->mContractID;
+    nsCAutoString converted;
+
+    converted.Append(contractID);
+
+    wrapper->SetData(converted.get());

It looks like we should be able to do the following:

     wrapper->SetData(entry->mContractID);

In general, ConvertFactoryEntryToCID(...) and ConvertContractIDKeyToString(...)
are incredibly inefficient !!!  Since they are called as enumerator functions we
might want to optimize them a bit ;-)  At the very least it seems like calling
do_CreateInstance() is a bit of a waste since the code is INSIDE OF THE
COMPONENT MANAGER !!  I'm sure there is a faster way to create components ;-)

Comment 1

[Doug Turner (:dougt)]

Neeti, please look at this when you have have a chance.  

Comment 2

[neeti]

Attachment: patch for optimization

Comment 3

[neeti]

doug: could you look at the patch when you get a chance.

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 68547 [details] [diff] [review]
patch for optimization

why are you going through the nsComponentManager static class?	Cant you just
use the global that should be available since you are in the
nsComponentManagerImpl.

Comment 5

[neeti]

Attachment: revised patch using global componentManager

Comment 6

[Doug Turner (:dougt)]

Comment on attachment 68608 [details] [diff] [review]
revised patch using global componentManager

just pass the "this" pointer into the "data" closure.

Comment 7

[neeti]

Attachment: revised patch

Attached a revised patch.

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 69090 [details] [diff] [review]
revised patch

make sure this compiles xp.  (I am worried that you didn't need to cast
|this|).  
Also, I believe that reinterpret cast is the wrong thing.... you want a static
cast... but I am not totally sure on that.
Other than that, r=dougt.

Comment 9

[neeti]

Attachment: revised patch casting "this", and using NS_STATIC_CAST

Comment 10

[Alec Flett]

Comment on attachment 69264 [details] [diff] [review]
revised patch casting "this", and using NS_STATIC_CAST

sr=alecf

Comment 11

[neeti]

fix checked in