122613 - Editor can't preview internal gopher images

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[[e-mail]]

There are some magic images used for example in FTP directory listings which
don't appear in editor's image preview, also IMHO should disable the relative
checkbox.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Charles Manske]

trivial problem, trivial fix by Neil.

Comment 3

[Charles Manske]

Comment on attachment 67095 [details] [diff] [review]
Proposed patch

r=cmanske

Comment 4

[Daniel Veditz [:dveditz]]

Comment on attachment 67095 [details] [diff] [review]
Proposed patch

sr=dveditz

Comment 5

[Charles Manske]

checked in

Comment 6

[sujay]

Neil,  does this work for you now?

Comment 7

[[e-mail]]

sujay, if you want a test sequence, do this:

1. Open ftp://ftp.mozilla.org/ in a new Composer window
2. Turn on Show All Tags mode otherwise the link eats the clicks :-(
   [Charley, does A need -moz-user-select: text !important; ?]
3. Left-click one if the images
4. Right-click the image and select Image Properties

Note that the image now appears in the image preview.

Comment 8

[sujay]

sorry but I don't understand the steps to verify this problem....

what magic images ?

Also in step 4 to right click...I don't see image props
in the context menu..

Comment 9

[[e-mail]]

> what magic images ?

Mozilla recognizes images with special names such as internal-gopher-menu

> Also in step 4 to right click...I don't see image props
> in the context menu..

This is easier to do in Show All Tags mode, could you try that?

Comment 10

[[e-mail]]

Oh, apparently Blake added drag and drop to images, now you can't edit them :-)

Comment 11

[sujay]

v