122787 - (nsIURI) nsStandardURL::SetFileName doesn't recalculate mPath

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Kathleen :Brade]

For publishing, I came across this interesting bug.
For publishing we create an nsIURI with an url that doesn't have the file
extension.  The extension is added later.  When the code calls
nsStandardURL::SetFileName to set the name with the extension, everything is
reset except mPath which is left as the path without the extension.  During
publishing, the HTTP put tries to GetPath but it doesn't get the whole path.

Regardless, this seems like it could be a pretty serious problem (if someone
SetFileName to "" or something less than what was there.

I have a fix in my own tree but I'm not an expert in this area so I'd like some
idea of the right approach (manually fix the mLen for mPath or call some other
method to do the recalculation).

Comment 1

[Darin Fisher]

brade: can you please provide some sample code that would demonstrate the
problem?  thx!

Comment 2

[Darin Fisher]

ok, i have a way to repro the problem -> 0.9.9 critical

Comment 3

[Darin Fisher]

Attachment: v1.0 patch

verified this patch using xpcshell...

  url.spec = "http://foo.com/bar/baz"
  url.fileName = "baz.html"

then i checked all of the nsIURI/nsIURL attributes and didn't see any problems.

Comment 4

[Darin Fisher]

Attachment: v1.1 patch

revised per comments from brade

Comment 5

[Doug Turner (:dougt)]

Comment on attachment 67298 [details] [diff] [review]
v1.1 patch

r=dougt

Comment 6

[Scott MacGregor]

Comment on attachment 67298 [details] [diff] [review]
v1.1 patch

sr=mscott

Comment 7

[Darin Fisher]

fixed-on-trunk