122849 - nsFileInputStream::ReadSegments loses data

Status: RESOLVED WORKSFORME

(Core :: Networking: File, defect)

Description

[John Keiser (jkeiser)]

nsFileInputStream::ReadSegments() tends to drop data when the writer callback is
unable to handle all the data that is passed to it.  This happens because the
writer callback in that case will simply return that it accepted less data than
it wrote.  There is an assertion there, but that is not enough.  To deal with
this, we must either:

1. return NS_ERROR_NOT_IMPLEMENTED
Or
2. Do a while() loop on the writer until either NS_BASE_STREAM_WOULD_BLOCK
occurs or the number of bytes accepted equaled the number of bytes in the
buffer; and then Seek() backwards just past the last byte that was accepted so
that next time we'll pick up from there.

Comment 1

[Doug Turner (:dougt)]

no.  by design consumers must handle all data.  wontfix

Comment 2

[Doug Turner (:dougt)]

jumping the gun.. cold medicine.. sorry.

Comment 3

[neeti]

wfm - this was fixed by bug 126829

Comment 4

[benc]

reporter: Can you VERIFY if this is fixed as neeti suggested?

Comment 5

[benc]

-> whitebox.