1229156 - Test ServiceWorkerEvents error reporting (ex: respondWith, waitUntil)

Status: NEW

(Core :: DOM: Service Workers, defect, P3)

Description

[Ben Kelly [:bkelly, not reviewing]]

We have a devtools test that covers console.log() from a service worker.  We should add something similar that checks for console error reporting when respondWith() fails, an exception is thrown, etc.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

I'm not currently working on this.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Were you thinking that these tests would be separate or should they piggy-back on the existing test coverage that triggers the error?

For example, https://dxr.mozilla.org/mozilla-central/source/dom/workers/test/serviceworkers/test_install_event.html covers the "throw in install" and "throw in activate" cases bug 1222720 wants better errors for.  The test seems complicated enough already that adding the console error checking might make the test harder to understand.

OTOH, https://dxr.mozilla.org/mozilla-central/source/dom/workers/test/serviceworkers/test_unresolved_fetch_interception.html which covers one of the respondWith() failing cases is reasonably straightforward and probably could handle some extra logic.

I don't think I've worked with the dom/ codebase long enough to have an opinion or totally grok what constitute best practices or what the desired convention is.  The trend I perceive is: new bugs get new tests, copying and pasting happens, not a lot of shared test support infrastructure beyond what SimpleTest.js and SpecialPowers offer.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

I was thinking new tests so that it would be easier to copy the devtools logging stuff:

https://dxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/test/test_console_serviceworker.html

But I don't have a strong opinion here.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

For context, we have existing tests at https://searchfox.org/mozilla-central/source/dom/serviceworkers/test/test_error_reporting.html which use the helpers at https://searchfox.org/mozilla-central/source/dom/serviceworkers/test/error_reporting_helpers.js.  There is also a test at https://searchfox.org/mozilla-central/source/dom/serviceworkers/test/test_unresolved_fetch_interception.html#66 that uses the helpers.

For this bug, this basically means that we want to make sure that all of the errors reported via AsyncLog and ReportToAllClients in https://searchfox.org/mozilla-central/source/dom/serviceworkers/ServiceWorkerEvents.cpp are covered.  This covers respondWith and waitUntil failures, in particular.