Closed
Bug 123031
Opened 24 years ago
Closed 24 years ago
Setting username and password on nsIURI object damages host part of URL, preventing FTP transfer
Categories
(Core :: Networking, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla0.9.9
People
(Reporter: cmanske, Assigned: darin.moz)
Details
Attachments
(1 file)
|
1.25 KB,
patch
|
cmanske
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
While testing publishing on Composer, we found that we can FTP using an nsIURI
object whose "spec" includes the username and password, but if we set the
username and password fields in the object, the FTP transfer fails.
Darin investigated this and found:
"nsIURI::host is getting wacked -- off by one error
nsIURI::host "@ftp.foo.com" becomes "@ftp.foo.co" after setting the username and
password"
|
Assignee | |
Comment 1•24 years ago
|
||
the problem is with nsStandardURL::SetPassword. it is not properly updating
mHost.mPos to account for the addition of the ':' character, i suspect.
patch in hand.
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.9
|
|
Assignee | |
Comment 2•24 years ago
|
||
trivial patch
|
Reporter | |
Comment 3•24 years ago
|
||
Comment on attachment 67478 [details] [diff] [review]
v1.0 patch
r=cmanske
Looks good.
Tested with publishing code
in Composer.
Attachment #67478 -
Flags: review+
|
||
Comment 4•24 years ago
|
||
Comment on attachment 67478 [details] [diff] [review]
v1.0 patch
sr=mscott
Attachment #67478 -
Flags: superreview+
|
|
Assignee | |
Comment 5•24 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•