123554 - [FIX]Print dialog does not pick up settings for printer from OS

Status: VERIFIED FIXED

(MailNews Core :: Printing, defect, P2)

Description

[Ian Neal]

BuildID 2002013003
If you have configured a printer under the OS to say be monochrome with A4 paper
size and then start mozilla and try to print, mozilla will not have picked up
these settings.

Comment 1

[Andrew Hagen]

Confirming on Windows 98, Build ID: 2002020208.

Actual behavior:  Mozilla is closed. In Control Panel | right click on {a
printer} | Properties. Change some setting, such as A4 paper or landscape
orientation. Click Ok. Open Mozilla. Go to File | Print | {same printer} |
Properties. The setting is the default, not what it was set to in Control Panel.

Expected behavior: Mozilla gets settings for printer from OS.

Old Summary: Print dialog does not pick up default settings for printer from OS
New Summary: Print dialog does not pick up settings for printer from OS

See also bug 83750.

Comment 2

[S A Jarrett-Sprague]

For non US people it is very important to remember that we use different 
paper. I don't want to keep changing to A4 every time I use mozilla.

Comment 3

[sujay]

*** Bug 123967 has been marked as a duplicate of this bug. ***

Comment 4

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

*** Bug 124349 has been marked as a duplicate of this bug. ***

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Here is what I said in bug 124349, duped to this one :

France uses A4 format but Mozilla switches the properties of the printer by
default to Letter.

This bug should be considered as a blocker in corporate environments where a
printer can be shared by dozens of people and where printers are not loaded
with Letter paper because it does not exist locally : the printer often asks*
for confirmation, or change of format and all print tasks are deferred.

Our printer here at Nscp France is configured in A4 (because that's the only
paper format we use in this country), my local printer config says A4, and
Mozilla always switches to Letter.

=> Setting severity, priority and expected milestone.

Comment 6

[Marcus Münch]

This referres not only to France but to Germany, too. This is really a blocker!

Comment 7

[Gilles Durys]

IIRC, the ISO paper sizes are widely used everywhere but North America.

Comment 8

[Johannes Almiala]

This really is an internationalization issue too, so someone empowered enough
should add the keyword intl.

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Nominating nsbeta1, adding intl kwd.

Comment 10

[Kevin McCluskey (gone)]

Rod will investigate what it will take to Initialize PrintSettings from system
default.

Comment 11

[rods (gone)]

Attachment: patch

In order to set the defaults we need to get a printer name, so the best thing
to do is to get the default printer's name.

This patch does the following:
1) On windows and OS/2 it implements IDL attr of "defaultPrinterName"
   (like Bug 118152)
2) Stubs this out on al other platforms
3) On Windows implmenets new method "InitPrintSettingsFromPrinter"
   which sets certain key values from the native devmode into the print
settings
4) Stubs this out on all other platforms
5) It also cleans up the nsDeviceContextSpecWin interface a little bit:
   It now has a single GetDevMode method that must be paired with a
UnlockDevMode
   method.
6) It moved GetDataFromPrinter into the public interface
7) Created a simple helper function for getting the default printer name.

Comment 12

[rods (gone)]

I opened new bugs for implementing the "InitPrintSettingsFromPrinter" OS2 and
GTK if it is possible, if not they can mark then "won't fix"

Comment 13

[Kevin McCluskey (gone)]

Marking nsbeta1+

Comment 14

[Marc Attinasi]

Comment on attachment 69085 [details] [diff] [review]
patch

sr=attinasi

Comment 15

[rods (gone)]

Attachment: additional patch for nsPluginViewer.cpp (it's stubbed out)

Comment 16

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

first test with first patch alone => need to add second patch
second test on Win2K              => works fine, solves the bug :-)

BUT this bug also needs to be solved on Mac and Linux for the same reasons
explained above. Keeping 'Letter' default is definitely a blocker outside of North
America.

Comment 17

[rods (gone)]

fixed

Comment 18

[Ian Neal]

So should another bug be logged to get the same problem fixed on Linux and Mac
OSes or should this one be reopened?

Comment 19

[sujay]

no need to file bugs...we already have other bugs
see bug 125078 and bug 125236

so we can close this bug out right? marking verified.
if this bug is not fixed, then REOPEN.

Comment 20

[Ian Neal]

Ah, should have known 125078 was refering to Linux, 125236 wasn't in the
blocking though (but now is hopefully).

Comment 21

[Gilles Durys]

*** Bug 125564 has been marked as a duplicate of this bug. ***

Comment 22

[Ian Neal]

Using buildID 2002021503

I still seem to have problems when I'm logged into Windows 2000 as user without
administrator rights. It picks up the wrong paper size (Letter instead of A4)
and when you click on cancel, it crashes Mozilla and produces a talkback
(TB3044781X)

Comment 23

[Ian Neal]

Additionally, even when you have administrator rights if you select two messages
to print at the same time, it picks up A4 for the first but uses letter for the
second.

Comment 24

[rods (gone)]

If I set the default paper size as administrator, and then log into an account
without admin priv. This other account has it's own default for the printer
size. If I set the size to A4 as the default when I am that user and then print,
it picks up the correct default size.

Where are you when you press "Cancel" and it crashes?

Comment 25

[Matthias Versen [:Matti]]

*** Bug 126378 has been marked as a duplicate of this bug. ***

Comment 26

[Marcus Münch]

Well, i don't get Mozilla crashing when exiting the "Print Page" dialog via
cancel, but the Mozilla window is put into the background when I press cancel.
This should not happen.
OS: Windows 2000
Build: 2002021803

Comment 27

[Ian Neal]

If as a non-administrator, I check the paper size through the Start, Settings,
Printers, etc, it shows up as being A4. If I check through Mozilla, clicking on
Print, Properties it shows up as being Letter. If I then cancel out of those
dialog boxes it is at that point it crashes (TB30962520W) or if I cancel out of
just the main print dialog box (TB3095818Q). This only happens within mail,
printing on the browser side has the correct paper size and doesn't crash. Even
tried with a different printer/driver and still crashes when I cancel on the
print dialog box (TB3096676W).

Comment 28

[rods (gone)]

Attachment: new patch

This patch:
1) Makes sure that when a PrintSettings is created it is initialized from the
default printer.
2) Mail now uses the nsIWebBrowserPrint interface to create the PrintSettings
object it caches and uses
3) Editor now creates and caches a PrintSettings object.

Comment 29

[rods (gone)]

Ian, this patch fixes the mail (and Editor) problems. The crash is a mail issue,
when the windows closes and it is taering down the content and frames it crashes
in a recycler. I'll file a bug.

Comment 30

[dcone (gone)]

Comment on attachment 70307 [details] [diff] [review]
new patch

r=dcone

Comment 31

[Marc Attinasi]

Comment on attachment 70307 [details] [diff] [review]
new patch

sr=attinasi

Comment 32

[(not reading, please use [e-mail] instead)]

Comment on attachment 70307 [details] [diff] [review]
new patch

r=sspitzer on the mailnews parts of the last patch.

Comment 33

[rods (gone)]

fixed

Comment 34

[Matthias Versen [:Matti]]

*** Bug 126608 has been marked as a duplicate of this bug. ***

Comment 35

[sujay]

Ian, does this work for you/everyone now? please verify..

let me know...thanks

Comment 36

[Ian Neal]

Does now have A4 for a non-administrator user, but still crashes if you cancel
out of the print dialog box (TB3164610H). Do you want me to log a separate bug
on that?

Comment 37

[Ian Neal]

Ah I see you logged bug 126427 on that.

Comment 38

[sujay]

marking this verified...if anyone is still having a problem 
with this, please REOPEN. thanks.

Comment 39

[Gilles Durys]

*** Bug 127223 has been marked as a duplicate of this bug. ***

Comment 40

[Gilles Durys]

*** Bug 127529 has been marked as a duplicate of this bug. ***

Comment 41

[Marcus Münch]

Hm. The new print dialog now seems to use the papersize of the default-printer
and not always letter as papersize.
But: I have four printers installed on my W2K machine. I get four entries in the
combobox where I can select the destination printer. All four entries are named
the same.
I have this four printers:
- HP LaserJet 4000 Series PCL (Default printer)
- Acrobat Distiller
- Acrobar Writer
- Fax

I get four printer entries called "HP LaserJet 4000 Series PCL". I open a new
bug for this.

Comment 42

[Marcus Münch]

Sorry, I forgot the build-ID: 2002022503

Comment 43

[Jochen Pawletta]

The problem is still the same, but this time in the "Mail and Newsgroups" part
of mozilla.
Can it also be fixed there? :-)

Comment 44

[Ian Neal]

This was originally to do with mail & news printing (I'm not sure how it changed
to browser printing) and it was fixed. This is a regression and I'll attempt to
mark as such.

Comment 45

[Ian Neal]

Printing was working fine in the build from 22nd February but broken again by
1st March build. I'll see if I can narrow it down further.

Comment 46

[rods (gone)]

Check checked in a minor fix that was intended to go into with Bug 131852, so
this is once again fixed. Check tomorrow's build or repull now.

Comment 47

[sujay]

Ian, can you verify this fix? if it is fixed, then please
mark this bug verified-fixed...thanks!

Comment 48

[sujay]

forgot to mention, the fix just went in..so wait till the next build to verify
it.

Comment 49

[Ian Neal]

I can't test to see if it is fixed or not because whenever I try to print from
mail & news I get the following pop-up box entitled "Printer Error"

The browser cannot print right now. Please try again when the page has finished
loading.

Of course the page had finished loading before I tried to print and clicking on
print again just brings up the same error again.

Using buildID 2002032110 on Win XP Pro

Comment 50

[rods (gone)]

I just backed out the fix for Bug 131174 that was causing mail not to print,
please retest and close this bug if it works.

Comment 51

[Syd Logan]

adt2 per adt triage, setting milestone to 1.0

Comment 52

[Ian Neal]

Tested on BuildID 2002032203 on Win XP and appears to be fixed again.

Comment 53

[sujay]

verified.