123768 - Unsubscribing while headers downloading hangs

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

To repro:
* Subscribe to a newsgroup with many articles.
* In the newsgroup pane, right-click on the newly subscribed newsgroup
* Mozilla starts downloading headers.  If "how many headers" dialog appears, 
select "All Headers".
* Mozilla displays context menu - select "Unsubscribe"
* Confirmation dialog - select "Yes".

Assuming that the headers are still being downloaded as you confirm the 
unsubscribe, Mozilla will hang on Windows.

Linux has a similar problem - however, instead of being truly hung, it is 
possible to click the "Stop" button and have Mozilla come back to life.  Under 
Windows, Stop does not do anything (the entire GUI has hung).

On a Windows debug build, I tracked down the problem.  It seems that 
nsNNTPProtocol::ReadXover() always returns a success code, even when 
m_newsgroupList->ProcessXOVERLINE() fails.  This means that the main state loop 
always remains in the NNTP_XOVER state, causing an infinite loop in 
nsNNTPProtocol::ProcessProtocolState().

Attaching a patch that solves the problem for me.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

Attachment: Proposed patch

Comment 2

[Håkan Waara]

Comment on attachment 68094 [details] [diff] [review]
Proposed patch

r=hwaara

You might want to trade that tab to spaces, though.

Comment 3

[Håkan Waara]

BTW, I've got a hunch that this may fix some other hang bugreports we have.

I just emailed sspitzer an sr= request.

Comment 4

[Håkan Waara]

Seth is on vacation. CCing other super-reviewers ... please take a look at
Mark's fix.

Comment 5

[Scott MacGregor]

Comment on attachment 68094 [details] [diff] [review]
Proposed patch

sr=mscott

Per the reviewer's guidelines on mozilla.org, please don't cc super reviewers
and ask for a review. Send email directly as the guidelines specify. Thanks.

Comment 6

[Håkan Waara]

Mark, do you need help checking this in, or will you do it yourself?

Comment 7

[Mark Hammond [:markh] [:mhammond]]

Taking.  Will check in as soon as the tree opens.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Checking in nsNNTPProtocol.cpp;
/cvsroot/mozilla/mailnews/news/src/nsNNTPProtocol.cpp,v  <--  nsNNTPProtocol.cpp
new revision: 1.311; previous revision: 1.310
done

Comment 9

[Håkan Waara]

Note to QA: this could potentially fix other hang bugs that are reported.

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with

RedHat 7.2 - 2002-02-12-08
Mac OS X 10.1.2 - 2002-02-12-03
Windows 2K - 2002-12-03

Mark, nice fix.