12398 - attribute selector parsing regression

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

DESCRIPTION:  I think (although I'm not sure) that this is a regression due to
introduction of CSS3 namespace support.  You do not parse the following
correctly:

[lang|="en"]

However, this works:

[lang |="en"]

STEPS TO REPRODUCE:  Load the attached test case.

ACTUAL RESULTS:  First line is green.  Second is black.

EXPECTED RESULTS:  Second line should instead be blue.

DOES NOT WORK CORRECTLY ON:
 * Linux, apprunner, 1999-08-20-13-M10
 * Linux, viewer, 1999-06-11-08

WORKS CORRECTLY ON:
 * Linux, viewer, 1999-06-01-13

ADDITIONAL INFORMATION:  I don't think this is a problem with the current
namespaces draft, but you might want to check.

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: testcase described in bug

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

ALSO DOES NOT WORK CORRECTLY ON:
 * Windows, apprunner, 1999-08-24-09-M10

Comment 3

[Peter Linss]

Moving non-beta 1 items to M15

Comment 4

[Pierre Saslawsky]

Reassigning peterl's bugs to myself.

Comment 5

[Pierre Saslawsky]

Accepting peterl's bugs that have a Target Milestone

Comment 6

[Pierre Saslawsky]

Pushing my M15 bugs to M16

Comment 7

[Hixie (not reading bugmail)]

Migrating from {css2} to css2 keyword. The {css1}, {css2}, {css3} and {css-moz}
radars should now be considered deprecated in favour of keywords.
I am *really* sorry about the spam...

Comment 8

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I took a look at this bug, and I found what seems to be a fix for it.  It's an
ugly fix, but I don't see an elegant way to do this.  (See
http://lists.w3.org/Archives/Public/www-style/2000Apr/0048.html for the
problem.)  I haven't tested the fix much yet.  Would you want to use a patch
this ugly?

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: possible patch to fix bug

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Technically, the CSS grammar handles this by having separate tokens for ~= and
|= .  That would be a much cleaner fix, although it might be a little more work
(though perhaps not).  I'll have a look...

Comment 11

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I have a much cleaner fix for this bug (changes the tokenization instead). 
Stealing bug.

Comment 12

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Accepting bug.  (Fix awaiting review.)

Comment 13

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Fix checked in 2000-04-26 17:12 PDT.

Comment 14

[ckritzer (gone)]

Marking VERIFIED FIXED on:
- MacOS9 2000-07-06-08-M17 Commercial
- Linux6 2000-07-09-20-M17 Commercial
- Win98  2000-07-09-21-M17 Commercial

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0065e207ab8
[components] Close https://github.com/mozilla-mobile/android-components/issues/12398: Add support for forcing menu orientation
https://hg.mozilla.org/integration/autoland/rev/79b5d3854420
[components] Close https://github.com/mozilla-mobile/android-components/issues/12398: Do not scroll menu to bottom with up orientation