Closed
Bug 124069
Opened 24 years ago
Closed 24 years ago
Remove scaling, 8 bit alpha blending code from nsImageGTK.cpp
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.9
People
(Reporter: nisheeth_mozilla, Assigned: nisheeth_mozilla)
Details
Attachments
(1 file, 1 obsolete file)
|
3.30 KB,
patch
|
pavlov
:
review+
tor
:
superreview+
|
Details | Diff | Splinter Review |
Clean up nsImageGTK::DrawToImage()
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Updated•24 years ago
|
Target Milestone: --- → mozilla0.9.9
|
|
Assignee | |
Comment 3•24 years ago
|
||
Attachment #68269 -
Attachment is obsolete: true
Comment on attachment 68395 [details] [diff] [review]
diff -u patch to remove code from DrawToImage()
Looks goood, less filling. sr=tor
Attachment #68395 -
Flags: superreview+
|
|
Assignee | |
Comment 5•24 years ago
|
||
Pav, can you review the fix to this bug for me?
I ran through the top100 sites using http://komodo.mozilla.org/buster and made
sure that the scaling and 8 bit compositing asserts added by my patch did not
fire. As Tim mentioned earlier in email, though, do you think AOL ART decoder
might support 8 bit transparent images on Linux? If so, then we have a problem.
If not, we're good to go.
|
||
Comment 6•24 years ago
|
||
Comment on attachment 68395 [details] [diff] [review]
diff -u patch to remove code from DrawToImage()
r=pavlov
Attachment #68395 -
Flags: review+
|
|
Assignee | |
Comment 7•24 years ago
|
||
Fix checked in.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 8•24 years ago
|
||
Marking verified because QA cannot test this.
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•