124070 - Password Manager records duplicate logins

Status: VERIFIED DUPLICATE of bug 153986

(SeaMonkey :: Passwords & Permissions, defect)

Description

[Robert Gelb]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.8) Gecko/20020204
BuildID:    2002020406

Password manager brings up a dialog asking me to choose from identical logins.

Reproducible: Always
Steps to Reproduce:
1.go to www.mozillazine.org and become a member
2.choose one of the stories and go into the discussion forum and post something
with your user/name password
3.Now go to mozillazine.org and go into the same story and post something again,
but with a different title now.
4.Now repeat step 3.  When coming into the story, you'll be presented with a
dialog box asking to choose from two identical logins.  
5. If you post something again, you'll get more identical logins to choose from.

Actual Results:  nothing

Expected Results:  I don't know what's the right way to resolve the situation -
you figure it out.

none

Comment 1

[Henrik Gemal]

yeps.. just seen it...
basiclly the stuff that calles the "select user" dialog should just delete 
duplicates and dont calls select user if there's only one username.

20020213

Comment 2

[Stephen P. Morse]

This is not the kind of site that password manager was designed to handle.  It 
was designed for a site that starts off with a username and this site starts off 
with a topic.  That is why you are getting the multiple entries -- each topic 
looks like a different username.

Comment 3

[Henrik Gemal]

not sure I understand. Getting multiple choises that are the same is very
confusing for a user. Ala: "Please select your option: [yes] [yes] [no] [yes]"

The dialog I got look like this
-------------------------
Select User:
[ moztest               ]
[ moztest               ]

[ Ok ]  [ cancel ]

Perhaps it's just that doesn't understand the logic behind the Password
Manager....:)

Comment 4

[Stephen P. Morse]

Perhaps I misunderstood.  Can you post a screenshot of the select-user dialog 
and also of the password-manager dialog.  Thanks.

Comment 5

[Henrik Gemal]

Attachment: screenshot of select user dialog

Comment 6

[Henrik Gemal]

Attachment: screenshot of password manager dialog

Comment 7

[Stephen P. Morse]

I didn't try to reproduce because I don't want to make false postings to a 
message board.  But I did look at the site and at the password-manager code and 
I believe I know what is happening.

BTW, forget what I said above about password manager considering the first field 
on the form as being the username.  I was mistaken.

Instead password manager uses the following heuristic.  When checking for a 
match on username, it tests the values of all non-password fields on the form.  
If any of them don't match the current value, it considers this to be a new 
user.  This accounts for the fact that the username field need not be the first 
field on the form.

The idea is that this is designed for a true login form, in which case you 
always log in with the same value (username/password) or set of values (perhaps 
username/e-mail-address/password).  It was not designed for a form used to post 
messages to newsgroups.

So I'd really like to mark this as won't fix because the user was mis-using the 
password manager.  It's unfortunate that the password manager pops up 
automatically and ask "do you want to save" for a site such as this since this 
is not a site that it can support.  However I don't know what to do instead.  Do 
I consider that if the value in any one of the non-password fields match, then 
this is the same user (and not create a new entry but rather overwrite the 
previous one)?  Do I reject forms (i.e., not even put up the do-you-want-to-save 
message) if they have more than one non-password field?  Other suggestions?

Comment 8

[Stephen P. Morse]

One more clarification on the heuristic.  Although I consider all the 
non-password fields together as defining the user, when I have to display a 
username (such as in the select-user dialog or in the password-manager dialog), 
I use the value in the first field.

Comment 9

[Henrik Gemal]

wrong use of not. Having a select dialog with two choses that are the same is
bad bad.

Comment 10

[Shark Daddy (Jonathan L.)]

*** Bug 128300 has been marked as a duplicate of this bug. ***

Comment 11

[Jesse Ruderman]

This would not be as bad if bug 104436 (Add delete button for multiple saved
password dialog) was fixed.  But this bug should still be fixed.

Comment 12

[Jesse Ruderman]

Related: bug 153986, Mozilla should use the text field just before the password
field as the username.

Comment 13

[Alex Bishop]

Actually, I'd say this is a dup.

*** This bug has been marked as a duplicate of 152986 ***

Comment 14

[Henrik Gemal]

not dupe of bug 152986! did you mean bug 153986 ?

Comment 15

[Alex Bishop]

You're right. I suck.

*** This bug has been marked as a duplicate of 153986 ***

Comment 16

[Terri Preston]

Verified Duplicate

Comment 17

[Ryan Pertusio]

*** Bug 173885 has been marked as a duplicate of this bug. ***