Closed
Bug 12408
Opened 25 years ago
Closed 25 years ago
[Feature][Dogfood] Focus and Command Dispatching
Categories
(Core :: XUL, defect, P1)
Core
XUL
Tracking
()
VERIFIED
FIXED
M12
People
(Reporter: hangas, Assigned: saari)
References
Details
(Whiteboard: [PDT+] 11/19)
We need to fix up the Focus and Command Dispatching stuff to work. Currently adding an event listener does not cause the event listeners onchange= to fire. We need to fix this. I think Dave wanted to call this oncommandupdate= instead of onchange=. I also believe that Dave thinks we can avoid having to add event listeners from JS and instead set an attribute in the xul.
Marking as M10 blocker and setting mailnews [dogfood] tracker to depend on this.
Updated•25 years ago
|
Priority: P3 → P1
Comment 2•25 years ago
|
||
bumping priority, need update.
Updated•25 years ago
|
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Comment 3•25 years ago
|
||
resolving as fixed, open new bugs on any specific issues
Updated•25 years ago
|
Whiteboard: [19990921] waiting to hear from reporter
Comment 4•25 years ago
|
||
Paul, can you please check this and let me know if you agree with the fix, thanks
Well the purpose of this bug was to track the focus and command dispatching feature. We do not yet have this feature. We have some changes to the interface which were very useful but we have some distance to go to get this nailed. I will get together with hyatt/waterson to find the other bugs and make this feature bug depend on them.
Updated•25 years ago
|
Target Milestone: M10 → M11
Comment 7•25 years ago
|
||
sounds like we're not going to get this in the next few days, moving to m11
Whiteboard: [19990921] waiting to hear from reporter → [PDT+][19990921] waiting to hear from reporter
Updated•25 years ago
|
Assignee: hyatt → trudelle
Status: REOPENED → NEW
Comment 9•25 years ago
|
||
reassigning to myself, dependency tracking bug.
Updated•25 years ago
|
Assignee: trudelle → saari
Comment 10•25 years ago
|
||
Whoops, I had this backward. That long list of bugs are the trackers that depend on this bug. reassigning to saari.
Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M11 → M12
Assignee | ||
Comment 11•25 years ago
|
||
This will hopefully be fixed by my initial focus landing in M12. Retargeting
Comment 12•25 years ago
|
||
Why is this marked a blocker?
Comment 13•25 years ago
|
||
> Why is this marked a blocker?
Well, there's the list of bugs which are dependent on this one ;-)
Whiteboard: [PDT+][19990921] waiting to hear from reporter → [PDT+]
Comment 14•25 years ago
|
||
That is what the dependency tree is for. A blocker is supposed to be like the old P0 priority, indicating that a developer can't do their job until the bug is fixed. It is supposed to indicate a super-critical severity that should trigger a fire drill priority for the assignee. As it is, there are so many 'blockers' that it has become meaningless as a severity, and engineers are starting to ignore it. We've even got one 'blocker' on the sidebar not saving open/closed state.
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] → [PDT+] 11/12
Assignee | ||
Comment 15•25 years ago
|
||
Paul, what else do you need here? Focus is checked in, but I'm not sure how to test your stuff in light of the M11 hackery.
Reporter | ||
Comment 16•25 years ago
|
||
Chris: I am backing out the M11 hackery today. Should be able to see how works this afternoon.
Assignee | ||
Updated•25 years ago
|
Whiteboard: [PDT+] 11/12 → [PDT+] 11/16 - Read the comment
Assignee | ||
Comment 17•25 years ago
|
||
I've committed all the changes I think we need for this. I want to make sure Paul is unblocked before closing this bug.
Assignee | ||
Updated•25 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Whiteboard: [PDT+] 11/16 - Read the comment → [PDT+] 11/19
Assignee | ||
Comment 18•25 years ago
|
||
I'm closing this bug as no one has objected.
Updated•25 years ago
|
Status: RESOLVED → VERIFIED
QA Contact: phillip → claudius
Comment 19•25 years ago
|
||
marking VERIFIED per previous comments.
You need to log in
before you can comment on or make changes to this bug.
Description
•