124269 - Selecting a folder doesn't enable ctrl-a to select all messages anymore

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[selmer (gone)]

2/4 06 098 build

Goto your mail 3 pane.
Click on a folder to select it.
Click on ctrl-a to select all messages.
note that the ctrl-a is ignored.

I had to select a message to get focus into the thread pane before ctrl-a would
work.  I believe this is a regression.

Comment 1

[Bozhan Boiadzhiev]

same on windows98SE build 20020530
but i've seen this on all bulids from M14 until now
ctrl+s and then ctrl+a selects all but delete botton is'n active

Comment 2

[Dimitrios]

*** Bug 142618 has been marked as a duplicate of this bug. ***

Comment 3

[(not reading, please use [e-mail] instead)]

accepting.

Comment 4

[(not reading, please use [e-mail] instead)]

the problem is the folder pane has focus, instead of the thread pane.

but select all / ctrl a makes no sense for our folder pane, which only allows 
single selection at this time.

I'm going to come up with a fix that makes select all / ctrl a do the right 
thing when the folder pane has focus.

My apologies for letting this rot for so long.  

asa / brendan, maybe this can squeek into the upcoming mozilla release?

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

for select all, forward the command to the thread pane controller.

Comment 6

[Asa Dotzler [:asa]]

Yes, we should get this in for 1.1 if possible. Adding to the 1.1 tracking bug. 

Comment 7

[David :Bienvenu]

Comment on attachment 94205 [details] [diff] [review]
patch

sr=bienvenu - is it possible not to have a thread pane controller?

Comment 8

[(not reading, please use [e-mail] instead)]

currently, our three pane has both folder and thread pane.

the thread pane control is defined in that same file, mail3PaneWindowCommands.js

Comment 9

[racham]

Comment on attachment 94205 [details] [diff] [review]
patch

r=bhuvan

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 94205 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to 1.1 branch

Comment 11

[(not reading, please use [e-mail] instead)]

Attachment: updated patch

new patch.  this is what I checked into the trunk.

it makes it so "select all" is disabled when there is no view (like bienvenu
pointed out).  this can happen when there is a server selected in the folder
pane so we are showing account central.

also, if we do forward the command, we then change focus.

"ctrl a / select all" is like clicking on the thread pane and doing select all.


a common usage is to select a folder (say SPAM) in the folder pane, and then to
do select all, delete.	if we don't switch focus, the delete will be for the
selected folder in the folder pane, which is not desired.

Comment 12

[David :Bienvenu]

how about just

return (gDBView != null);
+                                if (!gDBView) 
+                                  return false;
+				else
+                                  return true;  

Comment 13

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, following david's suggestion.

Comment 14

[David :Bienvenu]

Comment on attachment 94337 [details] [diff] [review]
updated patch, following david's suggestion.

thx, sr=bienvenu

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 94337 [details] [diff] [review]
updated patch, following david's suggestion.

a=asa (on behalf of drivers) for checkin to 1.1

Comment 16

[racham]

Comment on attachment 94337 [details] [diff] [review]
updated patch, following david's suggestion.

minor nit : 

please add semicolon after 

return (gDBView != null) 

thanks,
Bhuvan

Comment 17

[(not reading, please use [e-mail] instead)]

fixed on the trunk and the 1.1 branch.

I added the ; like racham suggested before checking in.

Comment 18

[laurel]

OK with nov1 commercila trunk: win98, mac OS 10.2, linux rh6.2