125688 - Move processmail to Template Toolkit.

Status: RESOLVED DUPLICATE of bug 124174

(Bugzilla :: Email Notifications, defect)

Description

[Matthew Tuck [:CodeMachine]]

processmail currently uses old style templatisation.  Moving over to template
toolkit will be a dramatic improvement.

This would allow an easy fix for bug #73330.  We should consider bug #26943 when
designing the template interface (and likely do it at the same time).  We should
probably also do bug #93952 to simplify the interface if we're doing bug #26943
at the same time.

Comment 1

[Bradley Baetz (:bbaetz)]

Can we make processmail a module, rather than a separate program, at the same
time? This would allow for us to pash hashes and lists through, rather than
parsing the bug_activity, and reading stuff from the command line, and so on.

Comment 2

[Matthew Tuck [:CodeMachine]]

We certainly can and should make it a sub, but I would be wary of doing things
that way.  The current way is semi-tolerant when notifications fail to get sent
out when they should.

Comment 3

[Bradley Baetz (:bbaetz)]

This is needed for several reasons:

1. problems running system on win32 without cmd in the path
2. This makes templatising process_bug.cgi a pain, because you have to process
half a template, then call processmail, then process the other half.

I'm hacking on this now. It won't be clean, but it won't be any worse than it
currently is, at least.

Comment 4

[Bradley Baetz (:bbaetz)]

The second problem can be worked arround like attachment.cgi does, though.

Comment 5

[Matthew Tuck [:CodeMachine]]

What are you doing exactly?  I wanted to do some hardcore redesign at the same
time as this.

Comment 6

[Bradley Baetz (:bbaetz)]

I wrote those comments on the wrong bug - see bug 124174, which now has a patch.
I'm avoiding doing any 'hardcore redesign' at this time.

Comment 7

[Dave Miller [:justdave]]

Changing default owner of Email Notifications component to JayPee, a.k.a.
J. Paul Reed ([e-mail]).  Jake will be offline for a few months.

Comment 8

[J. Paul Reed [:preed]]

From where I'm sitting now, this has become a dup of bug 124174, since we're
templatizing the new BugMail.pm; I'm gonna mark it as such now.

If anyone disagrees, please 'splain why in the comments.

*** This bug has been marked as a duplicate of 124174 ***

Comment 9

[Dave Miller [:justdave]]

clearing milestone on all DUPLICATE/WONTFIX/WORKSFORME/INVALID so they'll show
up as untriaged if they get reopened.  "Jiminy Cricket!" for the filters (and I
don't care if it's spelled wrong ;)