126042 - Dialogs should be confirmable with Keyboard, not mouse only

Status: RESOLVED FIXED

(SeaMonkey :: Installer, enhancement)

Description

[Olivier Cahagne]

Build 2002021708 on Linux (glibc 2.2.4).

Using nightly build:
http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-i686-pc-linux-gnu-sea.tar.gz

1. Launch mozilla-installer/mozilla-installer,
2. Click on 'Change default directory /usr/lib/mozilla',
3. Navigate to home directory /home/johndoe/,
4. Click on 'create directory',
5. Enter 'mozilla' within box (to create a mozilla/ directory),
6. Press 'Enter',
7. It doesn't validate,
8. Confirm by clicking on OK with mouse, then it works.

I believe it should be possible to confirm creating directory with keyboard, not
only with mouse.

Comment 1

[Andrew Schultz]

Attachment: patch

in fact none of the dialogs (except the error handler) have default actions.

this sets a default action for the dialogs for deleting an old installation
(cancel), insufficient disk space (ok), insufficient permission (ok) and
creating a destination directory (ok).	In the installer dialog, this sets a
default action for the dialogs for proxy settings (ok), CRC problem (ok), CRC
failure (ok) and connection dropped (ok).

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 143804 [details] [diff] [review]
patch

sr=dveditz

Comment 3

[Andrew Schultz]

checked in by timeless