126867 - [MFCEmbed] Page Info

Status: RESOLVED WONTFIX

(Core Graveyard :: Embedding: APIs, enhancement)

Description

[amutch]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; rv:0.9.8+) Gecko/20020220
BuildID:    MFCEmbed 2/20/2002 Build

Page Info needs to be implemented in MFCEmbed

Reproducible: Always
Steps to Reproduce:
1. Select View - Page Info


Actual Results:  Dialog box appears - "To be Done"

Expected Results:  Page Info should display in browser window

Comment 1

[timeless]

we don't have an embedding test application component.

Comment 2

[Adam Lock]

-> Chak

Comment 3

[Chak Nanga]

Marking it FUTURE...We're working on other priorites right now..sorry.

Comment 4

[amutch]

Future is fine. I just wanted to get it into the system for tracking.  Thanks!

Comment 5

[amutch]

Chak: Can this also include "View Frame Info" for viewing page info within
individual frames?  

Comment 6

[amutch]

Attachment: Patch to add ability to view page info. in MFCEmbed

This is code pulled from K-Meleon to allow page info. to be displayed. I'm not
sure that it is the cleanest patch but it does the job and would probably be
useful for testing. I'll file a separate bug and patch for view frame info. if
desired.

Comment 7

[timeless]

Comment on attachment 138465 [details] [diff] [review]
Patch to add ability to view page info. in MFCEmbed

>Index: BrowserView.cpp

>+   // Get the URI object we want to view from the cache.
>+   nsresult rv = NS_OK;
^ you don't need to declare rv here, especially with a value
>+   nsCOMPtr<nsIURI> currentURI;
you could declare it here:
>+   rv = mWebNav->GetCurrentURI(getter_AddRefs(currentURI));
>+   if(NS_FAILED(rv) || !currentURI) 
>+      return;
also, perhaps you don't need to check this rv at all?

the following questions are probably the most important...
>+   // Build the page info url
>+   nsCAutoString viewPageInfoUrl;

>+   if(uriString.Find("https://", 0) == -1)
>+      viewPageInfoUrl.Append("about:cache-entry?client=HTTP&sb=1&key=");
>+   else
>+      viewPageInfoUrl.Append("about:cache-entry?client=HTTP-memory-only&sb=1&key=");
what about moz-icon urls?

Consider: moz-icon:c:\.bmp?size=16
pair: about:cache-entry?client=image&sb=0&key=moz-icon:c:\.bmp?size=16

also, append is at least a bit silly given your string started out empty.
append would be better:

nsCAutoString viewPageInfoUrl("about:cache-entry?client=");
...
viewPageInfoUrl.Append("HTTP&sb=1&key=");

>     return pApp->CreateNewBrowserFrame(chromeMask, x, y, cx, cy, bShowWindow);
>+
> }
what style adds newlines after returns before the last brace in a function?

>+void CBrowserView::OpenURLInNewWindow(const char* pUrl)
>+{
>+	OpenURLInNewWindow(NS_ConvertASCIItoUCS2(pUrl).get());
>+}
but not here...
>+
why this extra line?
> 
> void CBrowserView::OpenURLInNewWindow(const PRUnichar* pUrl)
> {

Comment 8

[Ed Morley [:emorley]]

Mass marking all MFCEmbed bugs as wontfix, since bug 377410 removed it. If this bug was erroneously included (or say equally applies to winEmbed), please reopen & accept my apologies.

Filter bugspam on mfcEmbedwontfix.