Closed Bug 126932 Opened 23 years ago Closed 21 years ago

NSPR tests don't run on OS/2

Categories

(NSPR :: NSPR, defect, P3)

x86
OS/2
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julien.pierre, Assigned: wtc)

References

Details

Attachments

(2 files, 3 obsolete files)

Right now they don't even build on OS/2.
Depends on: 119098, 126931
Priority: -- → P3
Target Milestone: --- → 4.2
Blocks: 126923
Depends on: 126940
This is all that is needed - use $(LD) instead of $(LINK)
Now that the tests are building, we need to run runtests.ksh .
The standard mozilla OS/2 tools don't appear to include ksh. Mike, do 
you know which one we should use ?
Also, I think runtests.ksh will need some modifications for OS/2 in 
order to pick the correct tests to run.
Attached patch fix to runtests.sh (obsolete) — Splinter Review
runtests.sh should be used - it needs to be modified.

You also need printf and basename from gnusutils.
Attached patch Fix for sh and attach testcase (obsolete) — Splinter Review
Might as well put two fixes in - attach test is totally broke for os/2
Attachment #118645 - Attachment is obsolete: true
Attached patch Need direct.h for VACPP (obsolete) — Splinter Review
No idea why this is working for other platforms.

tmocon.c says that #includes are needed for getcwd
Michael, please update your patches against the current
NSPR client branch.
Status: NEW → ASSIGNED
Target Milestone: 4.2 → ---
Attached patch Current diffSplinter Review
Sorry, I didn't realize some of this went in.

This puts one more OS/2 in the .sh file and fixes an include problem in
thrpool_server.c

Once these changes are in, this bug is done.
Attachment #118648 - Attachment is obsolete: true
Attachment #118649 - Attachment is obsolete: true
Patch checked into the NSPR TIP and client branch.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Whiteboard: [4.3.1]
Target Milestone: --- → 4.3
Whiteboard: [4.3.1]
Target Milestone: 4.3 → 4.4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: