Closed
Bug 126937
Opened 23 years ago
Closed 22 years ago
PR_GetSysfdTableMax incorrectly implemented on OS/2, PR_SetSysfdTableSize not implemented
Categories
(NSPR :: NSPR, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
4.4.1
People
(Reporter: julien.pierre, Assigned: wtc)
Details
Attachments
(1 file, 1 obsolete file)
2.81 KB,
patch
|
jhpedemonte
:
review+
|
Details | Diff | Splinter Review |
On OS/2 this function assumes there is a max of 16K file handles open in the system.
The OS/2 control program doc says the maximum default is 50 for a process.
It can be queried with
APIRET rc = DosSetRelMaxFH(PLONG pcbReqCount, PULONG pcb CurMaxFH);
pcbReqCount is the signed number to be added or subtracted to the current max
file handle count for the process. Use 0 to query.
PULONG is a pointer to a ULONG where the current max for the process is returned.
The max can also be set in an absolute manner using
APIRET rc = DosSetMaxFH(ULONG count);
Reporter | ||
Updated•23 years ago
|
OS: other → OS/2
Priority: -- → P3
Hardware: Other → PC
Target Milestone: --- → 4.2
Reporter | ||
Comment 1•23 years ago
|
||
FYI this is in mozilla/nsprpub/pr/src/io/prfile.c
Reporter | ||
Updated•23 years ago
|
Summary: PR_GetSysfdTableMax incorrectly implemented on OS/2 → PR_GetSysfdTableMax incorrectly implemented on OS/2, PR_SetSysfdTableSize not implemented
Comment 2•22 years ago
|
||
Here's an implementation of PR_GetSysfdTableMax and PR_SetSysfdTableSize for
OS/2
Updated•22 years ago
|
Attachment #116430 -
Flags: review?(jpierre)
Updated•22 years ago
|
Attachment #116430 -
Flags: review?(jpierre) → review?(pedemont)
Comment 3•22 years ago
|
||
Comment on attachment 116430 [details] [diff] [review]
Fix
Dude, you are returning NO_ERROR on success rather than the number of file
handles.
Attachment #116430 -
Flags: review?(pedemont) → review-
Comment 4•22 years ago
|
||
I shouldn't even be checking RC. This API actually can't fail.
Attachment #116430 -
Attachment is obsolete: true
Updated•22 years ago
|
Attachment #127250 -
Flags: review+
Comment 5•22 years ago
|
||
wtc, could you please check this into NSPR?
Thanks
Assignee | ||
Comment 6•22 years ago
|
||
Patch checked into the NSPR trunk (NSPR 4.4.1) and
NSPRPUB_PRE_4_2_CLIENT_BRANCH (Mozilla 1.5a).
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Target Milestone: 4.2 → 4.4.1
You need to log in
before you can comment on or make changes to this bug.
Description
•