127226 - [crash] Ctrl+PageUp or Ctrl+PageDown in print preview mode

Status: VERIFIED FIXED

(Core :: Print Preview, defect, P3)

Description

[KM]

Step1. open some page by tab
Step2. open print preview
Step3. click the inside of a page
Step4. can change to another tab by 'Ctrl+PageUp' or 'Ctrl+PageDown'
       (print-preview-mode becomes strange behavior at this time)
Step5. click 'next page'
Step6. crash

I think behavior of Step4 is wrong.

I think Mozilla should exit from print-preview-mode after Step4.
or
I think print-preview-mode keep correct behavior after Step4,
and Mozilla should not crash after Step6.


buildID: 2002022103
OS: WindowsXP/2000 (Japanese)

Comment 1

[rcummins]

Crashes w2k build 2002022103

Talkback ID:
TB3239641Y

Comment 2

[Boris Zbarsky [:bzbarsky]]

stephend, would you get the stack?  TB3239641Y

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

0x00000000
nsMenuPopupFrame::FindMenuWithShortcut
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp, line 1479]
nsMenuPopupFrame::ShortcutNavigation
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuPopupFrame.cpp, line 1532]
nsMenuListener::KeyPress
[d:\builds\seamonkey\mozilla\layout\xul\base\src\nsMenuListener.cpp, line 228]
nsEventListenerManager::HandleEvent
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
1654]
nsXULDocument::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\document\src\nsXULDocument.cpp, line 2459]
nsXULElement::HandleDOMEvent
[d:\builds\seamonkey\mozilla\content\xul\content\src\nsXULElement.cpp, line 3441]
PresShell::HandleEventInternal
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 6005]
PresShell::HandleEvent
[d:\builds\seamonkey\mozilla\layout\html\base\src\nsPresShell.cpp, line 5928]
nsViewManager::HandleEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 2043]
nsView::HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 306]
nsViewManager::DispatchEvent
[d:\builds\seamonkey\mozilla\view\src\nsViewManager.cpp, line 1863]
HandleEvent [d:\builds\seamonkey\mozilla\view\src\nsView.cpp, line 83]
nsWindow::DispatchEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 860]
nsWindow::DispatchWindowEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 877]
nsWindow::DispatchKeyEvent
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 2643]
nsWindow::OnKeyDown
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 2718]
nsWindow::ProcessMessage
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 3454]
nsEventListenerManager::AddEventListener
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
466]
nsEventListenerManager::AddEventListenerByType
[d:\builds\seamonkey\mozilla\content\events\src\nsEventListenerManager.cpp, line
773]
USER32.DLL + 0x2e98 (0x77e12e98)
USER32.DLL + 0x6a72 (0x77e16a72)
USER32.DLL + 0x6aee (0x77e16aee)
nsWindow::WindowProc
[d:\builds\seamonkey\mozilla\widget\src\windows\nsWindow.cpp, line 1133]
USER32.DLL + 0x2e98 (0x77e12e98)
USER32.DLL + 0x39a3 (0x77e139a3)
0x0012fda4 

Comment 4

[Boris Zbarsky [:bzbarsky]]

The stack is identical to bug 126675.

KM, where are you clicking "Next Page"?  I can't reproduce the crash.....

Comment 5

[Samir Gehani]

Can't reproduce this crash either.  Does someone have a debug build that they
can crash this on?  I have an idea to fix this if it is originating from the
code that switches the browser into print preview mode.

Also, if the fix for bug 126675 fixes this then I'd like to address the first
issue here: disable tab switching use Ctrl + Pg{Up,Dn} key combinations.

Comment 6

[KM]

Attachment: 'Step5 next page' image

poor English - I'm sorry...

'next page' is meant in 'jump to next page'
please see screen-image.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Ah, I get it.  So the point is that you go to "next page" while viewing the
normal, non-preview page.  I missed that the first time.  :)  I can definitely
reproduce the crash, with a linux build from 2002-02-23:

Program received signal SIGSEGV, Segmentation fault.
0x411d300f in DocumentViewerImpl::GetPrintPreviewNumPages (this=0x8736840, 
    aPrintPreviewNumPages=0xbfffc978) at nsDocumentViewer.cpp:5226
5226      if (NS_FAILED(GetSeqFrameAndCountPages(mPrtPreview->mPrintObject,
seqFrame, *aPrintPreviewNumPages))) {
Current language:  auto; currently c++
(gdb) p mPrtPreview
$1 = (PrintData *) 0x0

#0  0x411d300f in DocumentViewerImpl::GetPrintPreviewNumPages (this=0x8736840, 
    aPrintPreviewNumPages=0xbfffc978) at nsDocumentViewer.cpp:5226
#1  0x40268995 in XPTC_InvokeByIndex (that=0x8736850, methodIndex=11, paramCount=1, 
    params=0xbfffc978) at xptcinvoke_unixish_x86.cpp:153
#2  0x40adee86 in XPCWrappedNative::CallMethod (ccx=@0xbfffca3c, mode=CALL_GETTER)
    at xpcwrappednative.cpp:1998

Just adding a null-check for mPrtPreview to
DocumentViewerImpl::GetPrintPreviewNumPages makes us not crash (though the
behavior is still wonky from a UI standpoint).

Comment 8

[Samir Gehani]

We should not be able to change tabs.  Null checks are always healthy too. 
Nominating.

Comment 9

[Peter Trudelle]

I don't see this crash using 030508 on Win2K

Comment 10

[Peter Trudelle]

...until I hit the submit button on this form immediately after. :-(

Comment 11

[Peter Trudelle]

nsbeta1+ per Nav triage team

Comment 12

[Peter Trudelle]

Reassigning 'several bugs at once' to Steve Morse, to level the load better
across the team.

Comment 13

[Blake Ross]

-> me

Comment 14

[Blake Ross]

Attachment: patch

Comment 15

[Blake Ross]

cc'ing hewitt for sr.

Comment 16

[Samir Gehani]

Is it a convention for attributes to be all lower case?

Comment 17

[Blake Ross]

this is now fixed.

Comment 18

[sujay]

KM is this problem fixed for you now? I can't reproduce anymore...

let us know...thanks.

Comment 19

[sujay]

marking verified...

Comment 20

[KM]

Mozilla don't crash. (BuildID:2002041603)

Blake-san, sujay-san, Thanks.