127408 - cant open directory viewer to local drive

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[[not reading bugmail]]

using build 2-22-03 w2k,

I try to enter c: or file:///c:/, or file:/c:/

I just get a dialog that tells me that file:/c:/ cannot be found. 

this is a regression.

Comment 1

[Mike Kaply [:mkaply]]

This happens on OS/2 as well. Changing OS to all and moving it to a better 
component.

Comment 2

[Bill Law]

It looks like we're passing plain "c:" to the docshell.  From there it does a
bunch of uri fixup kind of stuff.  I couldn't figure out at what point things
break down.

If somebody could say precisely when this broke, it would be real easy to figure
out what code changed to break it.

Comment 3

[Asa Dotzler [:asa]]

I can to the build search tomorrow to try to identify the day of the regression.
I think we really want this for 0.9.9 so I'm adding it to our tracking bug. Law,
do you think this is you or adamlock or someone else? (I guess pinpointing the
offending checkin will tell).

Comment 4

[[not reading bugmail]]

Ok, I've got several older builds here, I'll check to see If I can nail it down
by tomorrow evening for ya.

Comment 5

[[not reading bugmail]]

ok, that was easy, build 2-20 w2k (win32) works fine, build 2-21-03 w2k is broke.

bonsai: 02/20/2002 06:00 and 02/21/2002 12:00 :


http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=SeaMonkeyAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=02%2F20%2F02+06%3A00&maxdate=02%2F21%2F02+12%3A00&cvsroot=%2Fcvsroot

I'm going to take a stab at DougT: bug 122523, nsFileStreams., removing stat
call on opening file.

Comment 6

[Adam Lock]

Definitely appears to be this code.

http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsFileStreams.cpp#191

The call to nsILocalFile::OpenNSPRFileDesc is returning
PR_NO_ACCESS_RIGHTS_ERROR for drives and probably PR_IS_DIRECTORY_ERROR for
normal directories. This causes the code to code to return NS_ERROR_FILE_NOT_FOUND.

My guess is that if OpenNSPRFileSpec fails, the code should do an isDir to catch
drives and directions.

Doug, do you want to take this?

Comment 7

[Doug Turner (:dougt)]

sure.  over to darin.  I sent him a patch.

Comment 8

[Adam Lock]

Attachment: Proposed patch

Doug can you review this?

Patch calls IsDirectory if the file open fails and fixes a potential crasher if
method is called on a dir with contentLength as nsnull and contentType
non-nsnull.

Comment 9

[Darin Fisher]

my patch for bug 124042 incorporates dougt's fix for this already.

Comment 10

[Darin Fisher]

*** Bug 128491 has been marked as a duplicate of this bug. ***

Comment 11

[Darin Fisher]

*** Bug 128487 has been marked as a duplicate of this bug. ***

Comment 12

[Gilles Durys]

*** Bug 128912 has been marked as a duplicate of this bug. ***

Comment 13

[André Dahlqvist]

This is on the 0.9.9 radar apparently. Any progress with this bug?

Comment 14

[Suresh Duddi (gone)]

nominating for beta1 and mozilla 1.0

Comment 15

[Darin Fisher]

so this has been fixed on the trunk w/ the landing of my patch for bug 124042.

if that patch lands for 0.9.9, then it'll also be fixed there... so, hold onto
your horses...

Comment 16

[Alec Flett]

I can't imagine they're going to take an 100k+ patch on the 0.9.9 branch.. I
think we need a better way to fix this on 0.9.9

Comment 17

[Darin Fisher]

various drivers have been saying since the inception of bug 124042 that it
should go out w/ 0.9.9 in order to get sufficient coverage.  i am still waiting
to hear the final word from them.

Comment 18

[Adam Lock]

if not, then there's always my patch above.

Comment 19

[Matthias Versen [:Matti]]

*** Bug 129493 has been marked as a duplicate of this bug. ***

Comment 20

[benc]

+cc: gagan - shouldn't we plus this for nsbeta?

Comment 21

[Darin Fisher]

fixed-on-trunk, fixed-on-branch.

Comment 22

[benc]

qa to me.
another one of this necko qa testable docshell bugs.